Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torrent links not working in private window #3098

Open
Sh1d0w opened this issue Jan 25, 2019 · 4 comments
Open

Torrent links not working in private window #3098

Sh1d0w opened this issue Jan 25, 2019 · 4 comments
Labels
feature/private-browsing feature/webtorrent Label for webtorrent related issues priority/P4 Planned work. We expect to get to it "soon".

Comments

@Sh1d0w
Copy link

Sh1d0w commented Jan 25, 2019

Description

Torrent links or magnet links can not be opened in private windows. They work only in regular browser window.

Steps to Reproduce

  1. Open a private window
  2. Click a torrent or magnet link
  3. Profit???

Actual result:

screenshot 2019-01-25 at 7 04 22

Expected result:

screenshot 2019-01-25 at 7 06 25

Reproduces how often:

Every time

Brave version (brave://version info)

Version 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
@srirambv srirambv added feature/private-browsing feature/webtorrent Label for webtorrent related issues labels Jan 25, 2019
@srirambv
Copy link
Contributor

cc: @tomlowenthal

@srirambv srirambv added this to the 1.x Backlog milestone Jan 25, 2019
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Jan 25, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@btlechowski
Copy link

btlechowski commented Oct 14, 2019 •
edited
Loading

Still reproducible. Even in Tor Window we allow user to download the torrent file. In Private Windows we just block it.

Along with #6064 makes the torrent impossible to be downloaded in Private Window

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux

@btlechowski btlechowski mentioned this issue Oct 14, 2019
Closed
@btlechowski
Copy link

cc @feross

@feross
Copy link

feross commented May 4, 2020

Could this be related to the lazy load changes? brave/brave-core#3616 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/private-browsing feature/webtorrent Label for webtorrent related issues priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@feross @tildelowengrimm @Sh1d0w @rebron @srirambv @btlechowski