-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vertical lines overlapping under brave://settings/appearance
in Tabs
section
#30100
Comments
Kindly assign this to me. I would like to take care of this! |
@joshuakatt I've assigned you 😄 Feel free to reach out if you have any questions |
Hey @joshuakatt are you working on this? I'm a beginner so I'd like to work on this :D |
Hi @ItIsOHM Thanks for reaching out, but I'm currently working on this already! |
No worries! A side question, is there a way or some sort of an app that gives me an alert whenever a "good first issue", or generally any specified label issue is raised? It'll make it easier for newbies like me to keep up with the latest beginner friendly issues :D Sorry if it's wrong to discuss it here I just wasn't sure where to ask this. |
Hey @ItIsOHM, thanks for your interest! I don't think there is sorry, unless you're a member of the Brave organisation - the closest is probably refreshing the issues with that label unfortunately (and that's not very helpful). @bsclifton might know better though. |
@ItIsOHM I just tagged you on another issue, if you want to take a look |
Hey @fallaciousreasoning, can you assign me on any beginner friendly project? |
Hey , is anyone working on this issue , or is this issue is resolved ? |
The issue isn't resolved yet, feel free to submit a PR 😄 |
@fallaciousreasoning To submit a PR do I have to make changes in the brave/brave-core repo or I can directly submit changes to this repo? |
This issue will be fixed by my another PR(brave/brave-core#20409) |
The above requires |
Description
It's really hard to see but looks like there's two small vertical lines that are overlapping the other vertical lines via
brave://settings/appearance
under theTabs
section. See screenshot for example of the issue.Steps to Reproduce
vertical
tabs are enabled on your channel (enablebrave://flags/#brave-vertical-tabs
if not)brave://settings/appearance
and notice the issue (see screenshot for an example)Actual result:
Expected result:
It should be a single vertical line so it looks cleaner and not like we're stacking multiple vertical lines in one area.
Reproduces how often:
100% reproducible when using the STR/Cases outlined above.
Brave version (brave://version info)
Version/Channel Information:
Yes
(once1.51.x
goes out which is tomorrow)Yes
Yes
Other Additional Information:
N/A
N/A
N/A
Miscellaneous Information:
CCing @rebron @brave/qa-team
The text was updated successfully, but these errors were encountered: