Manually-blocked script source shows as null in Shields' Blocked count section

[stephendonner]

Description

Manually-blocked script source shows as null in Shields' Blocked count section

Steps to Reproduce

1. installed 1.52.23
2. launched Brave
3. logged in to facebook.com (yes, sorry, this is a requirement for this issue)
4. loaded https://apps.facebook.com/wordswithfriends
5. clicked on the Shields icon in the URL bar
6. clicked to toggle Block scripts to On / Enabled
7. clicked on the blocked-count #
8. clicked Allow beside https://apps.facebook.com
9. looked at the resulting path(s), under 20 Blocked scripts

Actual result:

null type/value shows up:

example	example	example	example	example	example

null application/x-javascript; charset=utf-8;base64,Oy8qRkJfUEtHX0RFTElNKi8KCl9fYW5ub3RhdG9yPWZ1bmN0aW9uKGEpe3JldHVybiBhfSxfX2Rfc3R1Yj1bXSxfX2Q9ZnVuY3Rpb24oYSxiLGMsZCxlKXtfX2Rfc3R1Yi5wdXNoKFthLGIsYyxkLGVdKX0sX19ybF9zdHViPVtdLHJlcXVpcmVMYXp5PWZ1bmN0aW9uKCl7X19ybF9zdHViLnB1c2goYXJndW1lbnRzKX07Ci8vIyBzb3VyY2VVUkw9aHR0cHM6Ly9zdGF0aWMueHguZmJjZG4ubmV0L3JzcmMucGhwL3YzL3lYL3IvUkJDYnp3T0NsU3IuanM/X25jX3g9bkpGMUhzSTcxYkMK

Expected result:

Actual FQDN/script URL

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.52.23 Chromium: 112.0.5615.49 (Official Build) nightly (x86_64)
Revision	bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS	macOS Version 13.4 (Build 22F5027f)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

/cc @MadhaviSeelam @spylogsster @rebron @pes10k @bsclifton

[stephendonner]

Also cc @fmarier

[pes10k]

Guessing this is what happens for scripts w/o sources? If thats the case, it should report the domain / site used for executing the frame (which most, but not all, of the time will just be from document.location)

[kjozwiak]

The above requires 1.51.95 or higher for 1.51.x verification 👍

[stephendonner]

Verified PASSED using

Brave	1.51.95 Chromium: 112.0.5615.121 (Official Build) beta (x86_64)
Revision	39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS	macOS Version 11.7.6 (Build 20G1231)

Steps:

1. installed 1.51.95
2. launched Brave
3. logged in to facebook.com (yes, sorry, this is a requirement for this issue)
4. loaded https://apps.facebook.com/wordswithfriends
5. clicked on the Shields icon in the URL bar
6. clicked to toggle Block scripts to On / Enabled
7. clicked on the blocked-count #
8. clicked Allow beside https://apps.facebook.com
9. looked at the resulting path(s), under 20 Blocked scripts

Confirmed there were no longer instances of null for either Allowed or Blocked scripts

example	example	example	example