Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong translation for copy clean link in Polish locale #29210

Closed
btlechowski opened this issue Mar 21, 2023 · 2 comments · Fixed by brave/brave-core#17889
Closed

Wrong translation for copy clean link in Polish locale #29210

btlechowski opened this issue Mar 21, 2023 · 2 comments · Fixed by brave/brave-core#17889
Assignees
@mkarolin
Labels
copy-clean-link l10n OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.50.x - Release

Comments

@btlechowski
Copy link

Current translation for Copy clean link: Skopiuj wyczyszczone lacze
Copy link translation: Kopiuj adres linku
Both should be similar

Steps to Reproduce

  1. Open context menu on a link on a page

Actual result:

translation for Copy clean link: Skopiuj wyczyszczone lacze

Expected result:

translation for Copy clean link: Kopiuj czysty adres linku or Kopiuj wyczyszczony adres linku

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.49.126 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

cc @rebron @mkarolin
@btlechowski btlechowski mentioned this issue Mar 21, 2023
Closed
@mkarolin mkarolin self-assigned this Mar 29, 2023
This was referenced Apr 3, 2023
Merged
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2023

The above requires 1.50.113 or higher for 1.50.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 4, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.50.113 Chromium: 112.0.5615.49 (Oficjalna wersja) (64-bitowa)
-- | --
Wersja | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
System operacyjny | Windows 10 Version 21H2 (Build 19044.2728)
  • Verified the description from the issue and ensured that the string copy clean link is translated in polish locale as Kopiuj wyczyszczony adres linku

image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
copy-clean-link l10n OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Updates l10n for 1.50.x release (lowered from 1.50.x). brave/brave-core
5 participants
@kjozwiak @btlechowski @GeetaSarvadnya @mkarolin @brave-builds