Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Filecoin EVM to preloaded networks #28954

Closed
jamesmudgett opened this issue Mar 8, 2023 · 4 comments · Fixed by brave/brave-core#17563
Closed

Add Filecoin EVM to preloaded networks #28954

jamesmudgett opened this issue Mar 8, 2023 · 4 comments · Fixed by brave/brave-core#17563
Assignees
@cypt4
Labels
feature/web3/wallet/core feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@jamesmudgett
Copy link

https://chainlist.org/chain/314
@jamesmudgett jamesmudgett added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/filecoin feature/web3/wallet/core priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 8, 2023
@yrliou
Copy link
Member

yrliou commented Mar 8, 2023

cc @cypt4

@cypt4 cypt4 mentioned this issue Mar 10, 2023
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Mar 10, 2023
@cypt4
FEVM support
6332c62 
Resolves brave/brave-browser#28954
cypt4 added a commit to brave/brave-core that referenced this issue Mar 14, 2023
@cypt4
FEVM support
b0a17a7 
Resolves brave/brave-browser#28954
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 15, 2023
@yrliou yrliou added OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 20, 2023
@kjozwiak kjozwiak mentioned this issue Mar 24, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.50.103 or higher for 1.50.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.106 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS Linux
  • Verified steps from brave/brave-core#17563
  • Verified upon upgrade to 1.50.76, Filecoin EVM Mainnet -0x13a https://api.node.glif.io/rpc/v1 & Filecoin EVM Testnet - 0x4cb2f https://api.calibration.node.glif.io/rpc/v1 is shown under network list
  • Verified Filecoin EVM Mainnet is enabled by default and Filecoin EVM Testnet is disabled by default
  • Verified able to send FIL on Filecoin EVM Testnet from one account to another
  • Verified clicking on View on blockchain explorer loads the correct block explorer
  • Verified sent transaction is listed under activity tab
  • Verified selecting FIL on Filecoin EVM Mainnet/Testnet shows all the accounts that hold the balance of the token
  • Verified able to hide network and hide the token from portfolio page
Transaction Upgrade scenario
28954-Transaction.mp4
28954-Upgrade.mp4

Verification passed on

Brave 1.50.106 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17563
  • Verified upon upgrade to 1.50.78, Filecoin EVM Mainnet -0x13a https://api.node.glif.io/rpc/v1 & Filecoin EVM Testnet - 0x4cb2f https://api.calibration.node.glif.io/rpc/v1 is shown under network list
  • Verified Filecoin EVM Mainnet is enabled by default and Filecoin EVM Testnet is disabled by default
  • Verified able to send FIL on Filecoin EVM Testnet from one account to another
  • Verified clicking on View on blockchain explorer loads the correct block explorer
  • Verified sent transaction is listed under activity tab
  • Verified selecting FIL on Filecoin EVM Mainnet/Testnet shows all the accounts that hold the balance of the token
  • Verified able to hide network and hide the token from portfolio page
Transaction Upgrade scenario
28954-Transaction.mp4
28954-Upgrade.mp4

Mainnet Transaction

  • Verified able to send FIL on FEVM Mainnet
  • Verified able to load block explorer from transaction menu/panel
  • Verified able to show/hide token from portfolio page
  • Eth Transaction Hash 0x41e30fbc33b8acee63700a1b509ea41d9329b8c34cd55fe852d3c1c8579ad3c1

Verification passed on

Brave 1.50.106 Chromium: 112.0.5615.39 (Official Build) beta (arm64)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17563
  • Verified upon upgrade to 1.50.76, Filecoin EVM Mainnet -0x13a https://api.node.glif.io/rpc/v1 & Filecoin EVM Testnet - 0x4cb2f https://api.calibration.node.glif.io/rpc/v1 is shown under network list
  • Verified Filecoin EVM Mainnet is enabled by default and Filecoin EVM Testnet is disabled by default
  • Verified able to send FIL on Filecoin EVM Testnet from one account to another
  • Verified clicking on View on blockchain explorer loads the correct block explorer
  • Verified sent transaction is listed under activity tab
  • Verified selecting FIL on Filecoin EVM Mainnet/Testnet shows all the accounts that hold the balance of the token
  • Verified able to hide network and hide the token from portfolio page
Transaction Upgrade scenario
28954-.Transaction.mp4
28954-Upgrade.mp4

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.50.107 x64 build

  • Verified steps from brave/brave-core#17563
  • Verified upon upgrade to 1.50.76, Filecoin EVM Mainnet & Filecoin EVM Testnet are shown under network list
  • Verified both Filecoin EVM Mainnet and Filecoin EVM Testnet are shown by default
  • Verified able to send FIL on Filecoin EVM Testnet from one account to another
  • Verified sent transaction is listed under token details screen
  • Verified selecting FIL on Filecoin EVM Mainnet/Testnet shows all the accounts that hold the balance of the token
  • Encountered #29295 & #29296, #29380
Transaction Upgrade Scenario
28954-Transaction.mp4
28954-Upgrade.mp4

Verification passed on Lenovo Tab with Android 12 running 1.50.107 x64 build

  • Verified steps from brave/brave-core#17563
  • Verified upon upgrade to 1.50.76, Filecoin EVM Mainnet & Filecoin EVM Testnet are shown under network list
  • Verified both Filecoin EVM Mainnet and Filecoin EVM Testnet are shown by default
  • Verified able to send FIL on Filecoin EVM Testnet from one account to another
  • Verified sent transaction is listed under token details screen
  • Verified selecting FIL on Filecoin EVM Mainnet/Testnet shows all the accounts that hold the balance of the token
  • Encountered #29295 & #29296, #29380
Transaction Upgrade Scenario
28954-Transaction.mp4
28954-Upgrade.mp4

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Apr 6, 2023
Closed
@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
This was referenced Sep 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/core feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

FEVM support brave/brave-core
6 participants
@jamesmudgett @kjozwiak @yrliou @srirambv @brave-builds @cypt4