Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 111.0.5563.50 to Chromium 111.0.5563.64. #28922

Closed
mkarolin opened this issue Mar 6, 2023 · 7 comments · Fixed by brave/brave-core#17502
Closed

Upgrade from Chromium 111.0.5563.50 to Chromium 111.0.5563.64. #28922

mkarolin opened this issue Mar 6, 2023 · 7 comments · Fixed by brave/brave-core#17502

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Mar 6, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/111.0.5563.50..111.0.5563.64?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) labels Mar 6, 2023
@mkarolin mkarolin self-assigned this Mar 6, 2023
@mkarolin mkarolin changed the title Upgrade from Chromium 111.0.5563.50 to Chromium 111.0.5563.58. Upgrade from Chromium 111.0.5563.50 to Chromium 111.0.5563.64. Mar 6, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Mar 7, 2023

The above requires 1.49.120 or higher for 1.49.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Mar 8, 2023

Quick update re: the work that remains on each platform/OS in terms of checking/verifying C111:

Still requires a check re: affected C111 areas

Affected C111 areas completed and require a quick spot check of 111.0.5563.41

@btlechowski
Copy link

Verification passed on

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

Full verification done it #28839 (comment)

image

@Uni-verse
Copy link
Contributor

Verified on Samsung GS 21 5G using version:

Brave	1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit) 
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Android 13; Build/TP1A.220624.014
  • Version bump
  • Check branding
Example Example
screenshot-1678297170039 screenshot-1678297284185

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 8, 2023

Verified on Samsung Galaxy Tab S7 running Android 12 using version:

Brave	1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit) 
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Android 12; Build/SP2A.220305.013

Spot checked affected areas mentioned in #28288 (comment) and checked versioning/branding items.

Ads notifications Web notifications NTP NTP (bg images off) share menu Uphold Version
screenshot-1678298691154 screenshot-1678297742714 screenshot-1678298726719 screenshot-1678298753053 screenshot-1678299012181 screenshot-1678300651262 screenshot-1678297580805

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1265)

image

@stephendonner
Copy link

stephendonner commented Mar 8, 2023

Carried on from #28839 (comment), which is now QA/No

Verification PASSED using

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.3 (b) (Build 22E7752300g)

Screenshot 2023-03-08 at 2 15 09 PM

Content settings - PASSED
  • Confirmed that Shields settings is been added in brave://settings/content (more info: Add Brave's Shields setting to brave://settings/content #12782)
  • Added few sites to shields up and shields down list and ensured sites got added to shield settings list
  • Open the sites (which are added in shield down list) in PT/TOR tab windows and ensured shields are down as expected
  • Confirmed content settings are working as expected
  • Confirmed cookies settings are working as expected

1. Block cookies content settings - PASSED

  • Open a site cnn.com
  • Open content settings for cnn.com
  • Block content settings for Location and Window management
  • Reload cnn.com
  • Ensured that Location and Window management permission are blocked for cnn.com
  • Open brave://settings/cookies and Block all cookies
  • Reload cnn.com and ensured that all cookies are blocked on cnn.com
Example Example Example Example Example Example
Screenshot 2023-03-08 at 1 15 28 PM Screenshot 2023-03-08 at 1 16 06 PM Screenshot 2023-03-08 at 1 19 03 PM Screenshot 2023-03-08 at 1 20 36 PM Screenshot 2023-03-08 at 1 22 44 PM Screenshot 2023-03-08 at 1 23 06 PM

2. Block scripts content settings - PASSED

  • Block the JavaScript for a site via brave://settings/content/javascript
  • Open the site ensured JavaScript blocked for the site
  • Open a bunch of websites and ensured JavaScript is not blocked
Example Example Example Example
Screenshot 2023-03-08 at 1 35 56 PM Screenshot 2023-03-08 at 1 36 00 PM Screenshot 2023-03-08 at 1 36 11 PM Screenshot 2023-03-08 at 1 36 25 PM

3. Block autoplay global settings - PASSED

  • Block the youtube.com autoplay content global settings via brave://settings/content/autoplay
  • Open youtube.com and ensured no videos are autoplayed
  • Click on a video and play the video manully, wait till the 1st video ends
  • Ensured 2nd video is not autoplayed
Example Example Example Example
Screenshot 2023-03-08 at 1 47 08 PM Screenshot 2023-03-08 at 1 50 02 PM Screenshot 2023-03-08 at 1 50 40 PM Screenshot 2023-03-08 at 1 50 52 PM
Verify that Brave policies (such as TorDisabled) work correctly when set - PASSED
  1. installed 1.49.120
  2. launched Brave
  3. pasted defaults write com.brave.Browser TorDisabled -bool true into a Terminal/console window, and pressed return
  4. launched Brave
  5. confirmed that the New Private Window with Tor menu option is removed
  6. opened brave://policies
  7. confirmed the correct entry for TorDisabled set to true is reflected
  8. shut down Brave
  9. pasted defaults delete com.brave.Browser TorDisabled
  10. launched Brave
  11. confirmed New Private Window with Tor menu option returned
Example Example Example Example Example
Screenshot 2023-03-08 at 2 04 33 PM Screenshot 2023-03-08 at 2 05 00 PM Screenshot 2023-03-08 at 2 11 28 PM Screenshot 2023-03-08 at 2 09 30 PM Screenshot 2023-03-08 at 2 09 45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment