Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Rewards should also disable Ads #2888

Closed
ryanml opened this issue Jan 10, 2019 · 4 comments · Fixed by brave/brave-core#1337
Closed

Disabling Rewards should also disable Ads #2888

ryanml opened this issue Jan 10, 2019 · 4 comments · Fixed by brave/brave-core#1337

Comments

@ryanml
Copy link
Contributor

ryanml commented Jan 10, 2019

Description

Disabling Rewards via the main toggle under brave://rewards should also disable Ads

Steps to Reproduce

  1. Enable Rewards
  2. If not automatically enabled, enable Ads.
  3. Verify you see some Ads after some time browsing
  4. Turn off Rewards (do not explicitly turn off Ads)

Actual result:

Ads is still enabled and notifications are still delivered

Expected result:

Ads should be disabled

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc
Copy link
Contributor

I think this needs to be fixed in ads library to check if rewards are enabled or not

@NejcZdovc
Copy link
Contributor

we do the same thing with everything else cc @bridiver @tmancey

@ryanml
Copy link
Contributor Author

ryanml commented Jan 12, 2019

Fixed with: brave/brave-core#1297

@LaurenWags
Copy link
Member

LaurenWags commented Feb 15, 2019

Verified passed with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verification passed on

Brave 0.60.29 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

Used test plan from brave/brave-core#1297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants