Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: setting as default may break import flow #28787

Closed
bsclifton opened this issue Feb 27, 2023 · 3 comments · Fixed by brave/brave-core#17460
Closed

Onboarding: setting as default may break import flow #28787

bsclifton opened this issue Feb 27, 2023 · 3 comments · Fixed by brave/brave-core#17460
Assignees
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include

Comments

@bsclifton
Copy link
Member

Description

Capturing feedback from brave/brave-core#17270

Has not been verified as an issue (yet) - but we should check this. If it's not an issue, we can close this out 😄

Steps to Reproduce

  1. Have a browser which isn't Brave registered as the default browser
  2. Install Brave (fresh install)
  3. In onboarding, accept Brave as the default browser
  4. You're prompted to import

Actual result:

Brave is now your default browser - but we should show what USED to be the default browser.

Expected result:

Whatever used to be your default should be the pre-selected choice for importing

@bsclifton bsclifton added onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop labels Feb 27, 2023
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 27, 2023
@spylogsster spylogsster self-assigned this Mar 1, 2023
@spylogsster spylogsster added this to the 1.51.x - Nightly milestone Mar 3, 2023
@MadhaviSeelam
Copy link

Reproduced using STR from #28787 (comment)

Brave | 1.50.107 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
-- | --
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Currently user pre-selected default browser (i.e. Edge) is shown on the Import Settings screen when clicked Skip on brave://welcome- first screen. However, when clicked Set Brave as default browser button, user's selection wasn't shown in the Import Settings screen.

Skip Set Brave as default browser
image image

@kjozwiak
Copy link
Member

The above requires 1.50.111 or higher for 1.50.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 4, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 4, 2023

Verification PASSED on

Brave | 1.50.113 Chromium: 112.0.5615.49 (Official Build) (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 10 Version 21H2 (Build 19044.2728)

Verified the issue on 1.50.113 and ensured that the user pre-selected default browser (i.e. Edge) is shown as selected on the Import Settings screen when Set Brave as default browser option is selected in the brave://welcome screen

Case 1:

  1. Set other browsers (apart from brave) e.g Chrome as default
  2. Clean install 1.50.113
  3. In brave://welcome screen, select Set Brave as default browser
  4. User pre-selected default browser (i.e. Chrome) is shown as selected on the Import Settings screen as expected
  5. Ensured that brave is default browser now
step 3 step 4
image image

Case 2:

  1. Set other browsers (apart from brave) e.g Edge as default
  2. Clean install 1.50.113
  3. In brave://welcome screen, select Skip
  4. User pre-selected default browser (i.e. Edge) is shown as selected on the Import Settings screen as expected
step 3 step 4
image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants