Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matic balance is not shown per accounts on PortfolioAsset view #28669

Closed
Pavneet-Sing opened this issue Feb 22, 2023 · 2 comments · Fixed by brave/brave-core#17353
Closed

Matic balance is not shown per accounts on PortfolioAsset view #28669

Pavneet-Sing opened this issue Feb 22, 2023 · 2 comments · Fixed by brave/brave-core#17353
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Feb 22, 2023 •
edited
Loading

Description

Matic balance is not shown per accounts on PortfolioAsset view

Actual result:

matic-balance.webm

Expected result:

Should show Matic balance

Reproduces how often:

easy

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel? Y
@Pavneet-Sing Pavneet-Sing added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Feb 22, 2023
@Douglashdaniel Douglashdaniel self-assigned this Feb 22, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Feb 22, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Feb 23, 2023
Merged
25 tasks
@kjozwiak kjozwiak mentioned this issue Feb 28, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.49.116 or higher for 1.49.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Mar 3, 2023

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#17353
  • Verified correct token details page is loaded when selecting asset from portfolio page
28669.mp4

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Wrong Selected Asset in Portfolio brave/brave-core
5 participants
@kjozwiak @Pavneet-Sing @srirambv @Douglashdaniel @brave-builds