Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up #28137] Deleting Swap input value retains the swap quotes #28618

Closed
srirambv opened this issue Feb 20, 2023 · 2 comments · Fixed by brave/brave-core#17312
Closed
Assignees
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Deleting Swap input value retains the swap quotes

Steps to Reproduce

  1. Select a token to swap
  2. Select a value or select pre-set values
  3. Wait for the swap quote to refresh
  4. Delete the input value of Swap token, quote refreshes and is retained

Actual result:

Swap.Quotes.mp4

Expected result:

Not sure maybe remove quotes

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.1105)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb @jamesmudgett @minkyeongshin

@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2023

The above requires 1.49.118 or higher for 1.49.x verification 👍

@srirambv
Copy link
Contributor Author

srirambv commented Mar 3, 2023

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from issue description
  • Verified deleting swap input resets swap quotes
28618.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants