Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional currencies that Transak supports to buy flow #28412

Closed
HEagle18 opened this issue Feb 9, 2023 · 5 comments · Fixed by brave/brave-core#17388
Closed

Add additional currencies that Transak supports to buy flow #28412

HEagle18 opened this issue Feb 9, 2023 · 5 comments · Fixed by brave/brave-core#17388
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@HEagle18
Copy link

HEagle18 commented Feb 9, 2023

Description

Right now, we only support USD, EUR and GBP on the buy flow. But we should extend that to other countries that Transak supports.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added OS/Android Fixes related to Android browser functionality OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 9, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 17, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 28, 2023
@muliswilliam
Copy link

@Pavneet-Sing @nuo-xu I added new currencies to currency list, please make sure Android and iOS are working as expected.

@Pavneet-Sing
Copy link

Pavneet-Sing commented Mar 2, 2023

@Pavneet-Sing @nuo-xu I added new currencies to currency list, please make sure Android and iOS are working as expected.

Thanks though Android yet to have a currency selector #27679

@nuo-xu
Copy link

nuo-xu commented Mar 8, 2023

thank you @muliswilliam
I've tested iOS with latest core, im seeing all these newly added currencies. and it works correctly for Transak provider.

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 13, 2023
@srirambv
Copy link
Contributor

Removing OS/Android label based on #28412 (comment). Android specific issue is #27679

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Mar 14, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from brave/brave-core#17388
  • Verified Transak landing page uses the selected currency on the purchase widget
28412.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17388
  • Verified Transak landing page uses the selected currency on the purchase widget

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17388
  • Verified Transak landing page uses the selected currency on the purchase widget
28412.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants