Crash in Retention Notification

[SergeyZhukovsky]

I found that in GPS for 1.49.81 version. We should fix and uplift to an appropriate channel. I think that we have some parts that are no initialized yet on such early stage and we better catch all exception and ignore as to me. In that case we will not show a retention notification and won't crash. The catch should be done in that place in my opinion https://github.com/brave/brave-core/blob/1.49.x/android/java/org/chromium/chrome/browser/notifications/retention/RetentionNotificationPublisher.java#L155

Crash stack:

Exception java.lang.RuntimeException:
  at android.app.ActivityThread.handleReceiver (ActivityThread.java:3202)
  at android.app.ActivityThread.-wrap18 (ActivityThread.java)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1664)
  at android.os.Handler.dispatchMessage (Handler.java:105)
  at android.os.Looper.loop (Looper.java:156)
  at android.app.ActivityThread.main (ActivityThread.java:6623)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:942)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:832)
Caused by java.lang.RuntimeException:
  at org.chromium.chrome.browser.preferences.ChromePreferenceKeyChecker.checkIsKeyInUse (ChromePreferenceKeyChecker.java:69)
  at org.chromium.chrome.browser.preferences.SharedPreferencesManager.readBoolean (SharedPreferencesManager.java:536)
  at org.chromium.chrome.browser.set_default_browser.BraveSetDefaultBrowserUtils.isBraveDefaultDontAsk (BraveSetDefaultBrowserUtils.java:222)
  at org.chromium.chrome.browser.notifications.retention.RetentionNotificationPublisher.onReceive (RetentionNotificationPublisher.java:109)
  at android.app.ActivityThread.handleReceiver (ActivityThread.java:3192)

[kjozwiak]

The above requires 1.49.100 or higher for 1.49.x verification 👍