Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.48.x (Chromium 110). #28287

Closed
mkarolin opened this issue Feb 3, 2023 · 5 comments · Fixed by brave/brave-core#17073
Closed

Update l10n for 1.48.x (Chromium 110). #28287

mkarolin opened this issue Feb 3, 2023 · 5 comments · Fixed by brave/brave-core#17073

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Feb 3, 2023

Download the latest l10n from Transifex.

Test plan:

@brave/legacy_qa should run through a few locals just to make sure that nothing obvious has regressed. Shouldn't spend too much time on this though.

@mkarolin mkarolin self-assigned this Feb 3, 2023
@MadhaviSeelam MadhaviSeelam added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 3, 2023
@brave-builds brave-builds added this to the 1.48.x - Release milestone Feb 7, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2023

Closing as brave/brave-core#17068 has been uplifted into 1.48.x as per brave/brave-core#17068 (review). The above requires 1.48.158 or higher for 1.48.x verification 👍

@kjozwiak kjozwiak closed this as completed Feb 7, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2023

@Uni-verse @srirambv note that Android specific translations haven't been ordered/completed. Those will be ordered once the Desktop translations are completed which are only ~43% completed. We'll see were we are with translations on Wednesday and decide if we release Wednesday or Thursday.

@mkarolin regarding Android, could get a list of specific strings that weren't translated with this PR?

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 7, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 7, 2023

Verification PASSED using

Brave | 1.48.158 Chromium: 110.0.5481.77 (Official Build) (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)

brave://welcome

German Portuguese(Brazil) Hindi Japanese
image image image image

BR Panel

German Portuguese(Brazil) Hindi Japanese
image image image image

brave://settings

German Portuguese(Brazil) Hindi Japanese
image image image image

brave://rewards

German Portuguese(Brazil) Hindi Japanese
image image image image

close all tabs

German Portuguese(Brazil) Hindi Japanese
image image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 7, 2023
@mkarolin
Copy link
Contributor Author

mkarolin commented Feb 9, 2023

@kjozwiak it varies by language a bit but around 40 strings have not been covered by this PR:

Tell us what you think!
Thanks!
Add your suggestions
Optional
In one emoji, how's your experience with Brave?
Rate now
Liking Brave?
Leave a Play Store rating?
Thanks for your feedback!
Let us know how we can improve Brave.
ENS offchain lookup
Ranked list of sources
Some sources you might like
Follow topics that interest you
Manage sources for your feed
Get Feeds
Getting Feeds...
SOURCES
No feeds found at %1$s
Your %1$s<ex>October</ex> Ads Rewards are here!
%1$s<ex>October</ex> Rewards: %2$s<ex>token</ex> BAT
You have %1$s<ex>89</ex> days left to claim
Sync account was deleted successfully
Failed to delete sync account
Contributions & tips
Background Images
Widgets
More private ads, more rewards.
%1$s Ads per hour
Continue to Ramp 
NFT Detail
Token Standard
Mint Address
Image not available
Cannot enable Safe Browsing
Safe Browsing has been disabled on your device. To enable it, ensure that Google Play Services is installed and that it's up to date.
This month, You've visited %1$s<ex>2</ex> creators supported by Brave Rewards
Accourding to Uphold, there are currently some limitations on your Uphold account. Please log in to your Uphold account and check whether there are any notices or remaining account requirements to complete, then try again.
Use ENS offchain domain

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 9, 2023

Verified on Samsung Galaxy S 21 5G using version:

Brave	1.48.160 Chromium: 110.0.5481.77 (Official Build) (64-bit) 
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Android 13; Build/TP1A.220624.014

  • Checked rewards, menus, NTP and shields strings to make sure they have not regressed in French, German and Russian locales.

Encountered: #28403

German
Example Example Example Example Example Example
screenshot-1675954684413 screenshot-1675954716782 screenshot-1675954807095 screenshot-1675954821447 screenshot-1675954827940 screenshot-1675954834771
Example Example Example Example
screenshot-1675955020167 screenshot-1675955041650 screenshot-1675955060744 screenshot-1675955333851
French
Example Example Example Example
screenshot-1675955847564 screenshot-1675955852776 screenshot-1675955861043 screenshot-1675955871175
screenshot-1675955905206 screenshot-1675955925602 screenshot-1675955941185 screenshot-1675955971851
Russian
Example Example Example Example
screenshot-1675958175015 screenshot-1675958185073 screenshot-1675958187146 screenshot-1675958197511
screenshot-1675958206837 screenshot-1675958216252 screenshot-1675958227493 screenshot-1675958282911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants