Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Brave Ads frequency capping #28271

Closed
tmancey opened this issue Feb 3, 2023 · 1 comment · Fixed by brave/brave-core#17022
Closed

Cleanup Brave Ads frequency capping #28271

tmancey opened this issue Feb 3, 2023 · 1 comment · Fixed by brave/brave-core#17022
Assignees

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 3, 2023

No description provided.

@btlechowski
Copy link

btlechowski commented Mar 21, 2023

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#17022

NTP SI - 1 hour cap:

[6576:6576:0405/161749.168650:VERBOSE2:permission_rule_util.cc(25)] New tab page ad cannot be shown as minimum wait time has not passed
[6576:6576:0405/161749.169629:VERBOSE1:new_tab_page_ad_serving.cc(65)] New tab page ad not served: Not allowed due to permission rules
[6576:6576:0405/161749.170450:VERBOSE1:ads_service_impl.cc(876)] Failed to prefetch new tab page ad

NTP SI - ads per day

[6924:6924:0405/162100.554493:VERBOSE2:permission_rule_util.cc(25)] You have exceeded the allowed new tab page ads per day
[6924:6924:0405/162100.555040:VERBOSE1:new_tab_page_ad_serving.cc(65)] New tab page ad not served: Not allowed due to permission rules
[6924:6924:0405/162100.555342:VERBOSE1:ads_service_impl.cc(876)] Failed to prefetch new tab page ad

NTP SI - ads per hour

[7466:7466:0405/162452.091051:VERBOSE2:permission_rule_util.cc(25)] You have exceeded the allowed new tab page ads per hour
[7466:7466:0405/162452.091563:VERBOSE1:new_tab_page_ad_serving.cc(65)] New tab page ad not served: Not allowed due to permission rules
[7466:7466:0405/162452.093083:VERBOSE1:ads_service_impl.cc(876)] Failed to prefetch new tab page ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants