Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Today CDN request sent on startup without Brave News enabled on a clean profile #28268

Closed
srirambv opened this issue Feb 3, 2023 · 2 comments · Fixed by brave/brave-core#17047

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2023

Description

Brave Today CDN request sent on startup without Brave News enabled on a clean profile

Steps to Reproduce

  1. Clean profile
  2. Check startup calls
  3. Open a new tab
  4. Shows request sent for brave-today-cdn.brave.com even though News is not enabled

Actual result:

Brave.Today.CDN.Startup.Call.mov

Expected result:

No start up calls unless required or opted into

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.48.151 Chromium: 109.0.5414.119 (Official Build) beta (arm64)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS macOS Version 13.0 (Build 22A380)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not checked
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Not checked

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @mattmcalister @rebron @mkarolin @aurangzaib048 @petemill

@kjozwiak
Copy link
Member

kjozwiak commented Feb 3, 2023

Verified the above as well. It's been happening for some time now, Whenever you load a NTP, you'll get a connection to the following end points:

  • http://brave-today-cdn.brave.com:433
  • http://brave-today-cdn.brave.com/sources.global.json

Reproducible on the latest version of Brave as well:

Brave | 1.47.186 Chromium: 109.0.5414.119 (Official Build) (64-bit)
-- | --
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | Windows 11 Version 22H2 (Build 22621.1194)
Example Example Example
news1 news2 news3

@stephendonner stephendonner changed the title Brave Today CND request sent on startup without Brave News enabled on a clean profile Brave Today CDN request sent on startup without Brave News enabled on a clean profile Feb 3, 2023
@kjozwiak kjozwiak added the feature/brave-news formerly brave-today label Feb 3, 2023
@ShivanKaul ShivanKaul added the privacy/discussed Discussed in privacy confab label Feb 14, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 28, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.50.94 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 10 Version 22H2 (Build 19045.2728)

Steps:

  1. installed 1.50.94
  2. launched Charles Proxy
  3. launched Brave Beta
  4. examined Charles Proxy for outbound network requests on startup/profile settling
  5. opened a new-tab page (with Brave News' opt-in dialog "peeking" up)
  6. again checked Charles Proxy for outbound network requests to brave-today-cdn.brave.com

Confirmed no more outbound requests to brave-today-cdn.brave.com on app startup + new window

1.50.94 1.49.120
image (1) image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment