Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 110.0.5481.52 to Chromium 110.0.5481.77 #28219

Closed
emerick opened this issue Feb 1, 2023 · 7 comments · Fixed by brave/brave-core#16987
Closed

Upgrade from Chromium 110.0.5481.52 to Chromium 110.0.5481.77 #28219

emerick opened this issue Feb 1, 2023 · 7 comments · Fixed by brave/brave-core#16987
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@emerick
Copy link
Contributor

emerick commented Feb 1, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/110.0.5481.52..110.0.5481.77

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Feb 1, 2023
This was referenced Feb 2, 2023
Merged
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2023

The above requires 1.48.155 or higher for 1.48.x verification 👍

@kjozwiak kjozwiak closed this as completed Feb 2, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2023 •
edited
Loading

Current pending verifications/work re: checks for C110 that were mentioned via #27221 (comment).

Completed platforms/verifications:

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 3, 2023
@stephendonner
Copy link

stephendonner commented Feb 3, 2023 •
edited
Loading

Verification PASSED using

Brave 1.48.155 Chromium: 110.0.5481.77 (Official Build) (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 13.2 (Build 22D49)
  • and (cookie-related settings section) -
Brave 1.48.157 Chromium: 110.0.5481.77 (Official Build) (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

brave://settings - PASSED

brave://settings - PASSED

Wallet is renamed to Web3 and IPFS has moved to brave://settings/web3

1.48.155 1.47.186
Screen Shot 2023-02-05 at 4 29 37 AM Screen Shot 2023-02-05 at 5 04 12 AM

brave://settings/clearBrowserData - PASSED

  • Verified Basic, Advanced, and On exit panels
Basic Advanced On exit
Screen Shot 2023-02-05 at 3 33 57 AM Screen Shot 2023-02-05 at 3 34 08 AM Screen Shot 2023-02-05 at 3 34 37 AM

brave://settings/appearance - PASSED

  • Confirmed Suggested sites option is removed from Show autocomplete suggestions in address bar
  • Sidebar and side panel options have been merged
1.48.155 1.47.186
Screen Shot 2023-02-05 at 4 32 35 AM Screen Shot 2023-02-05 at 5 06 39 AM

brave://settings/web3 - PASSED

  • Confirmed Resolve Unstoppable Domains and Resolve Ethereum Name Service (ENS) domains have moved here from brave://settings/extensions
1.48.155 1.47.186
Screen Shot 2023-02-05 at 4 24 58 AM Screen Shot 2023-02-05 at 5 07 23 AM

brave://settings/privacy - PASSED

1.48.155 1.47.186
Screen Shot 2023-02-05 at 5 46 23 AM Screen Shot 2023-02-05 at 5 16 50 AM

brave://settings/shields - PASSED

1.48.155 1.47.186
Screen Shot 2023-02-05 at 5 46 41 AM Screen Shot 2023-02-05 at 5 13 16 AM

Brave Wallet - PASSED

Tested by @srirambv in #28038 for CR110, and since, via desktop Wallet issue verification for 1.48.x 👍

cookie-related settings - PASSED

1.48.155 1.47.186
Screen Shot 2023-02-05 at 4 12 05 PM Screen Shot 2023-02-05 at 4 16 02 PM

Cookie settings:

  • confirmed cookie settings are retained in an upgraded profile
  • confirmed cookies settings are working as expected in brave://settings/cookies
  • confirmed local and global cookies Shields settings are working as expected
1.48.157 1.47.186
Screen Shot 2023-02-06 at 11 52 23 AM Screen Shot 2023-02-06 at 11 46 41 AM

Verification as follows:

  1. opened cnn.com and confirmed default setting of Block cross-site cookies shown in the Shields panel
  2. opened brave://settings/cookies and confirmed default setting of Block third-party cookies shown
  3. opened brave://settings/shields and confirmed default settings of Only cross-site shown
  4. changed the setting to Block all cookies in brave://settings/cookies
  5. reloaded cnn.com and confirmed Block all cookies are shown in the Shields panel as expected
  6. opened brave://settings/shields and confirmed Block cookies: All shown as expected
  7. opened brave://settings/cookies and selected Allow all cookies
  8. reloaded cnn.com and confirmed that Allow all cookies setting shown in the Shields panel as expected
  9. opened brave://settings/shields and confirmed Disabled shown as expected
  10. opened brave://settings/cookies and switch to Block third-party cookies
  11. reloaded cnn.com and confirmed Block cross-site cookies setting
  12. switched to Allow all cookies in the Shields panel for cnn.com site
  13. confirmed cnn.com is added to Sites that can always use cookies in brave://settings/cookies
  14. confirmed brave://settings/cookies is still showing Block third-party cookies setting
  15. deleted cnn.com entry from Sites that can always use cookies in brave://settings/cookies
  16. reloaded cnn.com and confirmed the setting was reverted to Block cross-site cookies in the shields panel
  17. change to Block all cookies in the Shields panel for cnn.com
  18. returned to brave://settings/cookies and confirmed www.cnn.com entry is displayed in Sites that can never use cookies
example example example example example example
Screen Shot 2023-02-06 at 12 40 08 PM Screen Shot 2023-02-06 at 12 44 31 PM Screen Shot 2023-02-06 at 12 45 02 PM Screen Shot 2023-02-06 at 12 45 14 PM Screen Shot 2023-02-06 at 12 45 26 PM Screen Shot 2023-02-06 at 12 48 28 PM
example example example example example
Screen Shot 2023-02-06 at 12 49 51 PM Screen Shot 2023-02-06 at 12 49 58 PM Screen Shot 2023-02-06 at 12 50 13 PM Screen Shot 2023-02-06 at 12 50 25 PM Screen Shot 2023-02-06 at 12 50 44 PM

Brave Sync - PASSED

Tested both via the manual pass in #28241, and also ad-hoc

Brave Search - PASSED

  • confirmed Brave as en-US defaults for both Normal and Private windows
  • confirmed list of remaining search engines
  • confirmed clicking on OK on the web infobar on search.brave.com toggles the Web Discovery Project preference to On/Enabled, in brave://settings/search
  • confirmed Private window searches used Startpage, as I set
  • confirmed Private window with Tor searches used Brave
  • confirmed autocomplete worked once enabled, in a Normal window
  • confirmed search-suggestion types in search: search terms, suggested domains/URLs, open tabs
example example example example example example example example
Screen Shot 2023-02-05 at 12 43 48 AM Screen Shot 2023-02-05 at 12 44 11 AM Screen Shot 2023-02-05 at 12 45 25 AM Screen Shot 2023-02-05 at 1 13 36 AM Screen Shot 2023-02-05 at 12 45 58 AM Screen Shot 2023-02-05 at 12 55 20 AM Screen Shot 2023-02-05 at 12 44 34 AM Screen Shot 2023-02-05 at 1 39 38 AM

side panel - PASSED

  • Confirmed sidebar is NOT shown by default in the release channel
  • Confirmed that sidebar is shown (when opened) on the left by default in the release channel
  • Confirmed side panel opens when clicking on the sidebar icon (i.e. Reading List and Bookmarks)
  • Confirmed the side panel can be opened/closed when toolbar button is toggled on/off
  • Confirmed reading list panel or bookmarks panel opened when clicking the toolbar button (whichever was the last open)
  • Confirmed when side panel opened, relevant sidebar icon (reading list or bookmarks) was selected
  • Confirmed the toolbar button shown as selected with highlighted gray background
  • Confirmed side panel can be opened/closed when bookmarks or reading list icons toggled on/off
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab button in the panel
  • Confirmed bookmarks are shown in the side panel
  • Confirmed that side panel is shown in all the window types (Normal, Private, Private window with Tor)
  • Confirmed if the sidebar is left-aligned and the button is shown accordingly
  • Confirmed if sidebar settings are changed to show on the right, side panel is shown on the right and toolbar is shown accordingly
default state side panel open bookmarks in side panel
Screen Shot 2023-02-04 at 11 57 58 PM Screen Shot 2023-02-04 at 11 59 07 PM Screen Shot 2023-02-05 at 12 03 27 AM

multiple profiles - PASSED

  • confirmed the user can create multiple profiles
  • opened brave://settings and imported bookmarks and extensions from Profile 1
  • ensured changes made in settings for Profile 1 are NOT reflected in Profile 2
  • ensured that the Rewards states between Profile 1 and Profile 2 are unique
  • confirmed I can edit the usernames and avatars, for Profile 1 and Profile 2
Screen Shot 2023-02-03 at 9 35 59 AM

Brave startup calls - PASSED (*)

Screen Shot 2023-02-05 at 4 04 25 PM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.48.155 Chromium: 110.0.5481.77 (Official Build) (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)

image

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.48.155 Chromium: 110.0.5481.77 (Official Build) (64-bit) 
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Android 13; Build/TP1A.220624.014

version

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.48.155 Chromium: 110.0.5481.77 (Official Build) (64-bit) 
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Android 12; Build/SP2A.220305.013

version

@LaurenWags LaurenWags mentioned this issue Feb 6, 2023
Closed
@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 6, 2023
@btlechowski
Copy link

Verification passed on

Brave 1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Ubuntu 18.04 LTS

brave://settings - PASSED

brave://settings - PASSED

Wallet is renamed to Web3 and IPFS has moved to brave://settings/web3

image

brave://settings/clearBrowserData - PASSED

  • Verified Basic, Advanced, and On exit panels
Basic Advanced On exit
image image image

brave://settings/appearance - PASSED

  • Confirmed Suggested sites option is removed from Show autocomplete suggestions in address bar
  • Sidebar and side panel options have been merged

image

brave://settings/web3 - PASSED

  • Confirmed Resolve Unstoppable Domains and Resolve Ethereum Name Service (ENS) domains have moved here from brave://settings/extensions

image

brave://settings/privacy - PASSED

image

brave://settings/shields - PASSED

image

Brave Wallet - PASSED

Tested by @srirambv in #28038 for CR110, and since, via desktop Wallet issue verification for 1.48.x 👍

cookie-related settings - PASSED

Cookie settings:

  • confirmed cookie settings are retained in an upgraded profile
  • confirmed cookies settings are working as expected in brave://settings/cookies
  • confirmed local and global cookies Shields settings are working as expected

image

Verification as follows:

  1. opened cnn.com and confirmed default setting of Block cross-site cookies shown in the Shields panel
  2. opened brave://settings/cookies and confirmed default setting of Block third-party cookies shown
  3. opened brave://settings/shields and confirmed default settings of Only cross-site shown
  4. changed the setting to Block all cookies in brave://settings/cookies
  5. reloaded cnn.com and confirmed Block all cookies are shown in the Shields panel as expected
  6. opened brave://settings/shields and confirmed Block cookies: All shown as expected
  7. opened brave://settings/cookies and selected Allow all cookies
  8. reloaded cnn.com and confirmed that Allow all cookies setting shown in the Shields panel as expected
  9. opened brave://settings/shields and confirmed Disabled shown as expected
  10. opened brave://settings/cookies and switch to Block third-party cookies
  11. reloaded cnn.com and confirmed Block cross-site cookies setting
  12. switched to Allow all cookies in the Shields panel for cnn.com site
  13. confirmed cnn.com is added to Sites that can always use cookies in brave://settings/cookies
  14. confirmed brave://settings/cookies is still showing Block third-party cookies setting
  15. deleted cnn.com entry from Sites that can always use cookies in brave://settings/cookies
  16. reloaded cnn.com and confirmed the setting was reverted to Block cross-site cookies in the shields panel
  17. change to Block all cookies in the Shields panel for cnn.com
  18. returned to brave://settings/cookies and confirmed www.cnn.com entry is displayed in Sites that can never use cookies

image
image
image
image
image
7 image
8 image
9 image
10 image
11 image
12 image
13 14 image
15 image
16 image
17 image
18 image

Brave Sync - PASSED

Tested both via the manual pass in #28244, and also ad-hoc

Brave Search - PASSED

  • confirmed Brave as en-US defaults for both Normal and Private windows
  • confirmed list of remaining search engines
  • confirmed clicking on OK on the web infobar on search.brave.com toggles the Web Discovery Project preference to On/Enabled, in brave://settings/search
  • confirmed Private window searches used Startpage, as I set
  • confirmed Private window with Tor searches used Brave
  • confirmed autocomplete worked once enabled, in a Normal window
  • confirmed search-suggestion types in search: search terms, suggested domains/URLs, open tabs

image
image
image
image
image

side panel - PASSED

  • Confirmed sidebar is NOT shown by default in the release channel
  • Confirmed that sidebar is shown (when opened) on the left by default in the release channel
  • Confirmed side panel opens when clicking on the sidebar icon (i.e. Reading List and Bookmarks)
  • Confirmed the side panel can be opened/closed when toolbar button is toggled on/off
  • Confirmed reading list panel or bookmarks panel opened when clicking the toolbar button (whichever was the last open)
  • Confirmed when side panel opened, relevant sidebar icon (reading list or bookmarks) was selected
  • Confirmed the toolbar button shown as selected with highlighted gray background
  • Confirmed side panel can be opened/closed when bookmarks or reading list icons toggled on/off
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab button in the panel
  • Confirmed bookmarks are shown in the side panel
  • Confirmed that side panel is shown in all the window types (Normal, Private, Private window with Tor)
  • Confirmed if the sidebar is left-aligned and the button is shown accordingly
  • Confirmed if sidebar settings are changed to show on the right, side panel is shown on the right and toolbar is shown accordingly
default state side panel open bookmarks in side panel
image image image

multiple profiles - PASSED

  • confirmed the user can create multiple profiles
  • opened brave://settings and imported bookmarks and extensions from Profile 1
  • ensured changes made in settings for Profile 1 are NOT reflected in Profile 2
  • ensured that the Rewards states between Profile 1 and Profile 2 are unique
  • confirmed I can edit the usernames and avatars, for Profile 1 and Profile 2

image

Brave startup calls - PASSED

Tested in #28244

This was referenced Feb 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 110.0.5481.52 to Chromium 110.0.5481.77 brave/brave-core
9 participants
@stephendonner @kjozwiak @emerick @Uni-verse @LaurenWags @btlechowski @mkarolin @brave-builds @MadhaviSeelam