Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in tab icon is not shown for NFT #28202

Open
srirambv opened this issue Feb 1, 2023 · 3 comments
Open

Open in tab icon is not shown for NFT #28202

srirambv opened this issue Feb 1, 2023 · 3 comments
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes suggestion

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 1, 2023

Description

Open in tab icon is not shown for NFT

Steps to reproduce

  1. Add an NFT to portfolio (Solana/ETH)
  2. Open NFT details view
  3. Open in new tab shortcut is not shown next to Mint Address/Token ID

Actual result

Solana ETH
image image

Expected result

Should be similar to

Desktop iOS
image image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.49.75

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv srirambv added suggestion QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 1, 2023
@srirambv
Copy link
Contributor Author

srirambv commented Feb 1, 2023

cc: @simoarpe @Pavneet-Sing

@simoarpe
Copy link

simoarpe commented Feb 1, 2023

@srirambv is this required for Android?
It's not part of the Figma design for Android.
Attaching a (very low-res) screenshot
Cursor_and_Screenshot_from_2023-02-01_16-03-36_png

@Pavneet-Sing
Copy link

I did noticed the icon next to link during review but ignored because (as @simoarpe mentioned) Figma didn't have it. Probably can add it as an enhancement.

I believe there are many places where desktop or iOS is showing open link icon next to links so if we need this then will have to add this icon in all the missing places.

@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes suggestion
Projects
Status: Backlog
Development

No branches or pull requests

4 participants