Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR 110] remove Block third-party cookies in Private setting #28176

Closed
rebron opened this issue Jan 31, 2023 · 11 comments · Fixed by brave/brave-core#16942
Closed

[CR 110] remove Block third-party cookies in Private setting #28176

rebron opened this issue Jan 31, 2023 · 11 comments · Fixed by brave/brave-core#16942
Assignees

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 31, 2023

Description

Remove Block third-party cookies setting in Private as it's unnecessary and conflicts with Shields.
See: brave://settings/cookies

Actual result:

Screenshot 2023-01-31 at 10 50 07 AM

Expected result:

Screenshot 2023-01-31 at 11 52 32 AM

Reproduces how often:

Easily.

Brave version (brave://version info)

1.49.x with Chromium 110

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? yes

Miscellaneous Information:

@rebron rebron added this to the 1.48.x - Beta milestone Jan 31, 2023
@rebron rebron added feature/settings priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude labels Jan 31, 2023
@bridiver
Copy link
Contributor

I don't understand, how does this conflict with shields? This is the default setting that we use.

@emerick
Copy link
Contributor

emerick commented Jan 31, 2023

I think there's a typo in this issue @rebron. It should be referencing the second radio button labelled "Block third-party cookies in Private".

@bridiver
Copy link
Contributor

Do you mean remove "block third party cookies in private"?

@rebron rebron changed the title [CR 110] remove Block third-party cookies setting [CR 110] remove Block third-party cookies in Priavte setting Jan 31, 2023
@rebron rebron changed the title [CR 110] remove Block third-party cookies in Priavte setting [CR 110] remove Block third-party cookies in Private setting Jan 31, 2023
@rebron
Copy link
Collaborator Author

rebron commented Jan 31, 2023

Correct. Block third party cookies in private setting.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 1, 2023

We'll move back into 1.48.x once brave/brave-core#16884 has been merged into 1.48.x.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 1, 2023

The above requires 1.48.153 or higher for 1.48.x verification 👍

@stephendonner stephendonner changed the title [CR 110] remove Block third-party cookies in Private setting [CR 110] remove Block third-party cookies in Private setting Feb 2, 2023
@stephendonner
Copy link

@brave/qa-team this is blocked by #28261 👍

@LaurenWags
Copy link
Member

Removed QA/Blocked as this can be verified in 1.48.155 and higher where #28261 is included.

@LaurenWags
Copy link
Member

Verified with

Brave | 1.48.155 Chromium: 110.0.5481.77 (Official Build) (x86_64)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | macOS Version 12.6.3 (Build 21G419)

Confirmed Block third-party cookies in Private setting is no longer displayed under brave://settings/cookies.

1 48 x

@LaurenWags
Copy link
Member

Removed QA/Test-All-Platforms label per discussion with @kjozwiak @rebron but we will want to verify this one on Windows.

@MadhaviSeelam
Copy link

Verification PASSED with

Brave | 1.48.155 Chromium: 110.0.5481.77 (Official Build) (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Install 1.48.155
launch Brave
open brave://settings/cookies

Confirmed Block third-party cookies in Private setting is no longer displayed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants