Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pinning gateway-like urls #28169

Closed
cypt4 opened this issue Jan 31, 2023 · 1 comment · Fixed by brave/brave-core#17505
Closed

Allow pinning gateway-like urls #28169

cypt4 opened this issue Jan 31, 2023 · 1 comment · Fixed by brave/brave-core#17505
Assignees
@cypt4
Labels
feature/web3/ipfs feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.51.x - Release

Comments

@cypt4
Copy link

cypt4 commented Jan 31, 2023

Some of tokens contain urls in the form of gateway urls for both metadata and image.
For example : https://bafybeia6xpwokfar3zkev3cvipfwyoejpswumakd57ctsvnrwkhvwhl3jq.ipfs.nftstorage.link/3193.json
In this case we can extract CID to pin from the url.
@cypt4 cypt4 self-assigned this Jan 31, 2023
@cypt4 cypt4 added feature/web3/ipfs priority/P4 Planned work. We expect to get to it "soon". labels Jan 31, 2023
cypt4 added a commit to brave/brave-core that referenced this issue Mar 6, 2023
@cypt4
Allow pinning of gateway-like urls
2f49b9e 
Resolves brave/brave-browser#28169
@cypt4 cypt4 mentioned this issue Mar 7, 2023
Merged
25 tasks
@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Mar 8, 2023
cypt4 added a commit to brave/brave-core that referenced this issue Mar 8, 2023
@cypt4
Allow pinning of gateway-like urls
3cd84a8 
Resolves brave/brave-browser#28169
cypt4 added a commit to brave/brave-core that referenced this issue Mar 10, 2023
@cypt4
Allow pinning of gateway-like urls
fa52670 
Resolves brave/brave-browser#28169
cypt4 added a commit to brave/brave-core that referenced this issue Mar 10, 2023
@cypt4
Gateway-like urls pinning support (#17505)
3f0fbad 
* Gateway-like urls pinning support
Allow pinning of gateway-like urls
Resolves brave/brave-browser#28169
Show only pinned NFTs count in the IPFS banner
Resolves brave/brave-browser#28928
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 10, 2023
@cypt4 cypt4 mentioned this issue Mar 13, 2023
Closed
cypt4 added a commit to brave/brave-core that referenced this issue Mar 16, 2023
@cypt4
Gateway-like urls pinning support (#17505)
5baa09a 
* Gateway-like urls pinning support
Allow pinning of gateway-like urls
Resolves brave/brave-browser#28169
Show only pinned NFTs count in the IPFS banner
Resolves brave/brave-browser#28928
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.51.80 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 11 Version 22H2 (Build 22621.1344)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/ipfs feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Gateway-like urls pinning support brave/brave-core
4 participants
@yrliou @srirambv @brave-builds @cypt4