Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiteRemovalNotification doesn't disappear w/o explicit user closing #2772

Closed
simonhong opened this issue Jan 1, 2019 · 4 comments · Fixed by brave/brave-core#1194
Closed

Comments

@simonhong
Copy link
Member

simonhong commented Jan 1, 2019

SiteRemovalNotification doesn't disappear after reloading, creating new tab, or browser restart.
It is only disappears when user explicitly closes it.

screen shot 2019-01-01 at 3 33 13 pm

Description

Steps to Reproduce

  1. Remove thumbnail
  2. Thumb Removed notification is visible
  3. Try new tab reloading, new tab creation or browser restart

Actual result:

Thumb Removed notification is visible

Expected result:

Thumb Removed notification should be hidden

Reproduces how often:

Always

Brave version (brave://version info)

Latest stable/beta/dev/nightly

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?
    no

Additional Information

@simonhong
Copy link
Member Author

simonhong commented Jan 1, 2019

@cezaraugusto I'm trying to fix this.
If this is intended behavior, please close this.

@rebron
Copy link
Collaborator

rebron commented Jan 4, 2019

cc: @rossmoody can you take a look?

@rossmoody
Copy link
Contributor

That's interesting. Muon behavior was for it to persist until closed inside the NTP you are currently in but not carry over to new ones. This is a little out of my troubleshooting comfort zone so gonna tag in @cezaraugusto.

@btlechowski
Copy link

btlechowski commented Feb 26, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1194

Brave 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint

Verified test plan from brave/brave-core#1194

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

@rebron rebron changed the title SiteRemovalNotification isn't disappeared w/o explicit user closing SiteRemovalNotification doesn't disappear w/o explicit user closing Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment