Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Local Storage pref for Portfolio Filters #27364

Closed
Douglashdaniel opened this issue Dec 14, 2022 · 1 comment · Fixed by brave/brave-core#16959
Closed

Add Local Storage pref for Portfolio Filters #27364

Douglashdaniel opened this issue Dec 14, 2022 · 1 comment · Fixed by brave/brave-core#16959
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to add Local Storage prefs for the Portfolio Filters to persist the users choice.

  • Network Filter Option
  • Asset Filter Option
  • Account Filter Option

Screen Shot 2022-12-13 at 11 44 25 PM
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 14, 2022
@Douglashdaniel Douglashdaniel self-assigned this Dec 14, 2022
@HEagle18 HEagle18 mentioned this issue Jan 12, 2023
Closed
This was referenced Jan 12, 2023
Closed
Closed
@Douglashdaniel Douglashdaniel mentioned this issue Feb 1, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 2, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from brave/brave-core#16959
  • Verified Network, Account and Asset Filter changes are retained between page refresh on Portfolio page
27364.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#16959
  • Verified Network, Account and Asset Filter changes are retained between page refresh on Portfolio page
27364.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16959
  • Verified Network, Account and Asset Filter changes are retained between page refresh on Portfolio page
27364.mov

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Local Storage Pref Portfolio Filters brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds