Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT asset details screen #27276

Closed
jamesmudgett opened this issue Dec 9, 2022 · 2 comments · Fixed by brave/brave-core#16671
Closed

NFT asset details screen #27276

jamesmudgett opened this issue Dec 9, 2022 · 2 comments · Fixed by brave/brave-core#16671
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@jamesmudgett
Copy link

jamesmudgett commented Dec 9, 2022 •
edited
Loading

Screen Shot 2022-12-09 at 10 03 22 AM

simulator_screenshot_B8C8929E-533B-4A05-8895-D8AAFAA712ED

Match iOS on NFT display:

  • Reuse asset details screen and remove the graph for NFTs.
  • Display additional labels needed for metadata: description, collection, etc.
  • Display accounts and transactions related to the NFT
@jamesmudgett jamesmudgett added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Dec 9, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Dec 13, 2022
Closed
@simoarpe simoarpe self-assigned this Dec 30, 2022
@simoarpe simoarpe mentioned this issue Jan 13, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 24, 2023
@simoarpe simoarpe mentioned this issue Jan 25, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.48.151 or higher for 1.48.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023

Verification passed on the following devices running 1.48.155 x64 build

  • Verified steps from brave/brave-core#16671
  • Verified NFT asset details view is shown when clicked on the NFT
  • Verified clicking on the Token ID loads the NFT's page on blockexplorer
  • Verified able to view both Solana NFT and Ethereum NFT
  • Encountered #28202
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
27276-ARM.mp4
27276-Tab.mp4

This was referenced Feb 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Implement NFT asset details screen brave/brave-core
5 participants
@jamesmudgett @kjozwiak @simoarpe @srirambv @brave-builds