Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all images for unverified publishers on Brave Rewards #2696

Closed
mandar-brave opened this issue Dec 22, 2018 · 2 comments · Fixed by brave/brave-core#1182
Closed

Remove all images for unverified publishers on Brave Rewards #2696

mandar-brave opened this issue Dec 22, 2018 · 2 comments · Fixed by brave/brave-core#1182
Assignees
@NejcZdovc
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.58.x - Release ...

Comments

@mandar-brave
Copy link

mandar-brave commented Dec 22, 2018 •
edited
Loading

For the Tip-Panel, Tip-Banner, Thank you pages, remove the images for unverified publishers. Leave verified flow intact.

cc @NejcZdovc @diracdeltas @davidtemkin
@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Dec 22, 2018
@NejcZdovc NejcZdovc self-assigned this Dec 22, 2018
@NejcZdovc NejcZdovc mentioned this issue Dec 22, 2018
Merged
18 tasks
@NejcZdovc NejcZdovc added this to the 0.58.x - Release Hotfix 1 milestone Dec 22, 2018
@jasonrsadler jasonrsadler reopened this Dec 22, 2018
This was referenced Dec 23, 2018
Closed
Closed
@kjozwiak
Copy link
Member

Went through verifications on the following platforms:

  • macOS 10.14.2 x64 - Verification PASSED
  • Ubuntu 18.04.1 x64 VM - Verification PASSED

Used the following build:

Brave 0.58.17 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}

screen shot 2018-12-23 at 8 27 20 am

screen shot 2018-12-23 at 8 27 36 am

screen shot 2018-12-23 at 8 29 46 am

screen shot 2018-12-23 at 8 27 50 am

screen shot 2018-12-23 at 8 27 57 am

@kjozwiak
Copy link
Member

Possible Issues

It appears that we're still displaying favicons under the Rewards panel for websites, example:

screen shot 2018-12-23 at 8 31 44 am

screen shot 2018-12-23 at 8 31 53 am

This was referenced Dec 23, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.58.x - Release Hotfix 1 (Release Ch...
Development

Successfully merging a pull request may close this issue.

Show media publishers images only when verified brave/brave-core
4 participants
@kjozwiak @NejcZdovc @jasonrsadler @mandar-brave