Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove widgets and supporting code #26865

Closed
bbondy opened this issue Nov 18, 2022 · 3 comments · Fixed by brave/brave-core#16027
Closed

Remove widgets and supporting code #26865

bbondy opened this issue Nov 18, 2022 · 3 comments · Fixed by brave/brave-core#16027

Comments

@bbondy
Copy link
Member

bbondy commented Nov 18, 2022

  • Remove FTX widget (already disabled for the whole user base but removing the rest of the code)
  • Remove Binance widget
  • Remove crypto.com widget
  • Remove Gemini widget
  • Remove suggested sites (disabled by default and not used)
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 18, 2022
@bbondy bbondy self-assigned this Nov 18, 2022
@bbondy
Copy link
Member Author

bbondy commented Nov 18, 2022

FYI @rebron

@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Nov 25, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 5, 2023
@srirambv srirambv added feature/widgets and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Jan 31, 2023
@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2023

Verification passed on

Brave 1.48.155 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Linux
  • Verified steps from brave/brave-core#16027
  • Verified widgets are removed post update
  • Verified Suggested Sites setting is also removed post update
  • Verified on a clean profile there are no widgets available and Suggested Sites settings is not available
26865.mp4

Verification passed on

Brave 1.48.155 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16027
  • Verified widgets are removed post update
  • Verified Suggested Sites setting is also removed post update
  • Verified on a clean profile there are no widgets available and Suggested Sites settings is not available

Verification passed on

Brave 1.48.155 Chromium: 110.0.5481.77 (Official Build) (arm64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16027
  • Verified widgets are removed post update
  • Verified Suggested Sites setting is also removed post update
  • Verified on a clean profile there are no widgets available and Suggested Sites settings is not available
26865.mp4

@Uni-verse
Copy link
Contributor

Verified on Samsung GS 21 using version:

Brave	1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit) 
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Android 13; Build/TP1A.220624.014
  • Ensured the setting show suggested sites in autocomplete is removed on fresh profile
  • Ensured the setting suggested sites setting is removed on upgraded profile
  • Ensured suggested sites are not shown in the search content area on 1.48.157 if setting was enabled in previous version
1.47.x 1.48.157
screenshot-1675714634783 screenshot-1675714691906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants