Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Implement NFT Pinning #26828

Closed
muliswilliam opened this issue Nov 17, 2022 · 1 comment · Fixed by brave/brave-core#16998
Closed

[Desktop] Implement NFT Pinning #26828

muliswilliam opened this issue Nov 17, 2022 · 1 comment · Fixed by brave/brave-core#16998

Comments

@muliswilliam
Copy link

muliswilliam commented Nov 17, 2022

Figma File

Figma Clickable link

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.106 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#16998
  • Verified able to pin an NFT locally
  • Verified with flag enabled, shows a banner message about NFT pinning
  • Verified clicking on Learn more loads interstitial page brave://wallet/crypto/local-ipfs-node
  • Verified selecting Check which NFTs of mine can be pinned on brave://wallet/crypto/local-ipfs-node shows how many of the added NFT's can be pinned
  • Verified Keep my NFTs always online on both brave://wallet/crypto/local-ipfs-node and brave://wallet/crypto/inspect-nfts enables the Automatically pin NFTs settings under brave://settings/web3/
  • Verified once an NFT is pinned shows how many NFT's are locally pinned in the same banner message
  • Verified clicking on a locally pinned NFT shows the CID and Image location or address link
  • Verified based on the setting for Method to resolve IPFS resources, Image location or address loads the image either via localhost or via gateway or brings up the interstitial page
  • Verified when IPFS is turned off NFT details page shows Local IPFS node is not running
  • Verified when IPFS is turned off and clicking the Image location or address automatically starts IPFS
  • Encountered #29354 #29200, #29199, #29009
26828.mp4

Verification passed on

Brave 1.50.106 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS Linux
  • Verified steps from brave/brave-core#16998
  • Verified able to pin an NFT locally
  • Verified with flag enabled, shows a banner message about NFT pinning
  • Verified clicking on Learn more loads interstitial page brave://wallet/crypto/local-ipfs-node
  • Verified selecting Check which NFTs of mine can be pinned on brave://wallet/crypto/local-ipfs-node shows how many of the added NFT's can be pinned
  • Verified Keep my NFTs always online on both brave://wallet/crypto/local-ipfs-node and brave://wallet/crypto/inspect-nfts enables the Automatically pin NFTs settings under brave://settings/web3/
  • Verified once an NFT is pinned shows how many NFT's are locally pinned in the same banner message
  • Verified clicking on a locally pinned NFT shows the CID and Image location or address link
  • Verified based on the setting for Method to resolve IPFS resources, Image location or address loads the image either via localhost or via gateway or brings up the interstitial page
  • Verified when IPFS is turned off NFT details page shows Local IPFS node is not running
  • Verified when IPFS is turned off and clicking the Image location or address automatically starts IPFS
  • Encountered #29354 #29200, #29199, #29009
26828.mp4

Verification passed on

Brave 1.50.106 Chromium: 112.0.5615.39 (Official Build) beta (arm64)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16998
  • Verified able to pin an NFT locally
  • Verified with flag enabled, shows a banner message about NFT pinning
  • Verified clicking on Learn more loads interstitial page brave://wallet/crypto/local-ipfs-node
  • Verified selecting Check which NFTs of mine can be pinned on brave://wallet/crypto/local-ipfs-node shows how many of the added NFT's can be pinned
  • Verified Keep my NFTs always online on both brave://wallet/crypto/local-ipfs-node and brave://wallet/crypto/inspect-nfts enables the Automatically pin NFTs settings under brave://settings/web3/
  • Verified once an NFT is pinned shows how many NFT's are locally pinned in the same banner message
  • Verified clicking on a locally pinned NFT shows the CID and Image location or address link
  • Verified based on the setting for Method to resolve IPFS resources, Image location or address loads the image either via localhost or via gateway or brings up the interstitial page
  • Verified when IPFS is turned off NFT details page shows Local IPFS node is not running
  • Verified when IPFS is turned off and clicking the Image location or address automatically starts IPFS
  • Encountered #29354 #29200, #29199, #29009
26826.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants