Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace at the beginning or end of the recovery key prevents wallet recovery #2665

Closed
btlechowski opened this issue Dec 20, 2018 · 1 comment · Fixed by brave/brave-core#1169

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Go to brave://rewards/
  2. In Manage You Wallet use a recovery key with whitespace at the end/beginning of the key (tried Space and Enter)
  3. Restore the wallet

Actual result:

image

User may get the wrong impression that wallet recovery does not work even though recovery key is correct.

Expected result:

Whitespace is trimmed from the beginning and the end of the recovery key

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.58.16 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

cc @NejcZdovc @brave/legacy_qa

@btlechowski btlechowski added this to the 1.x Backlog milestone Dec 20, 2018
@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 20, 2018
@NejcZdovc NejcZdovc self-assigned this Dec 21, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 21, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 21, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Feb 11, 2019

Verified passed with

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verification PASSED on Mint 19.1 x64 using the following build:

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Verification passed on

Brave 0.60.27 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants