Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Site banner icon visible #2614

Closed
rossmoody opened this issue Dec 18, 2018 · 2 comments · Fixed by brave/brave-ui#300
Closed

Make the Site banner icon visible #2614

rossmoody opened this issue Dec 18, 2018 · 2 comments · Fixed by brave/brave-ui#300
Assignees
@rossmoody
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.58.x - Release ...

Comments

@rossmoody
Copy link
Contributor

Update the color and shadow treatment for the icon in site banners to be more visible on light and dark backgrounds.

49309646-be4d3900-f490-11e8-94ba-5c6c54113871
@rossmoody rossmoody self-assigned this Dec 18, 2018
@rossmoody rossmoody mentioned this issue Dec 18, 2018
Merged
@rebron rebron added this to the 0.58.x - Release milestone Dec 18, 2018
@rebron rebron added the QA/Yes label Dec 18, 2018
@petemill
Copy link
Member

Closed via brave/brave-ui#300

@NejcZdovc NejcZdovc mentioned this issue Dec 18, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Dec 19, 2018
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Dec 19, 2018 •
edited by btlechowski
Loading

Verification PASSED on Ubuntu 18.04.1 x64 using the following build:

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

Before the fix (0.58.14):

screen shot 2018-12-18 at 11 18 24 pm

After the fix (0.58.15):

screen shot 2018-12-18 at 11 13 04 pm

Verified passed with

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

screen shot 2018-12-19 at 9 00 01 am

Verification passed on

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Site banner icon update brave/brave-ui
6 participants
@petemill @kjozwiak @rebron @LaurenWags @rossmoody @btlechowski