Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings header is not shown when loading brave://wallet or navigating to Wallet from Settings page #26093

Closed
srirambv opened this issue Oct 18, 2022 · 2 comments · Fixed by brave/brave-core#15500
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Settings header is not shown when loading brave://wallet or navigating to Wallet from Settings page

Steps to Reproduce

  1. Install 1.46.66
  2. Open a new tab and load brave://wallet
  3. No settings header bar is shown
  4. Open a new tab and load settings page, settings bar is shown with Wallet
  5. Click on wallet in header bar from settings page
  6. Brave wallet page loads but settings header is removed

Actual result:

image

Expected result:

Not sure

Reproduces how often:

East

Brave version (brave://version info)

Brave 1.46.66 Chromium: 107.0.5304.36 (Official Build) nightly (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22623.746)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @emerick @rebron

@kjozwiak
Copy link
Member

The above requires 1.45.106 for 1.45.x verification 👍

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 19, 2022
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Linux
  • Verified steps from issue description
  • Verified navigation bar is shown for brave://wallet as well
26093.mp4

Verification passed on

Brave 1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description
  • Verified navigation bar is shown for brave://wallet as well
26093.mp4

Verification passed on

Brave 1.45.106 Chromium: 107.0.5304.36 (Official Build) (arm64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from issue description
  • Verified navigation bar is shown for brave://wallet as well
26093.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants