Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove desktop support for Ropsten, Rinkeby, and Kovan test networks and add Sepolia #25654

Closed
nvonpentz opened this issue Sep 27, 2022 · 4 comments · Fixed by brave/brave-core#15266
Closed

Remove desktop support for Ropsten, Rinkeby, and Kovan test networks and add Sepolia #25654

nvonpentz opened this issue Sep 27, 2022 · 4 comments · Fixed by brave/brave-core#15266
Assignees
@nvonpentz
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release #4

Comments

@nvonpentz
Copy link

as they are being deprecated by our RPC provider October 5th.
@nvonpentz nvonpentz added priority/P2 A bad problem. We might uplift this to the next planned release. release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Sep 27, 2022
@nvonpentz nvonpentz self-assigned this Sep 27, 2022
@nvonpentz nvonpentz added this to Web3 Sep 27, 2022
@nvonpentz nvonpentz moved this to In Progress in Web3 Sep 28, 2022
@nvonpentz nvonpentz changed the title Remove desktop support for Ropsten, Rinkeby, and Kovan test networks Remove desktop support for Ropsten, Rinkeby, and Kovan test networks and add Sepolia Sep 28, 2022
@nvonpentz
Copy link
Author

I will also add Sepolia in this change because some tests depend there being two different Ethereum testnets. This way I can swap those with Sepolia and Goerli without having to modify the core test logic.

@nvonpentz nvonpentz mentioned this issue Sep 28, 2022
Merged
25 tasks
@nvonpentz nvonpentz added QA/Yes OS/Android Fixes related to Android browser functionality labels Sep 29, 2022
Repository owner moved this from In Progress to Done in Web3 Oct 3, 2022
@bbondy bbondy added this to the 1.46.x - Nightly milestone Oct 3, 2022
This was referenced Oct 3, 2022
Merged
Merged
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Oct 6, 2022

The above will require 1.44.109 or higher for 1.44.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Oct 7, 2022

Verification passed on

Brave 1.44.109 Chromium: 106.0.5249.103 (Official Build) (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Linux
  • Verified steps from brave/brave-core#15266
  • Verified deprecated networks are removed after update
  • Verified Sepolia & Goreli are the only two ETH test networks available after upgrade
  • Verified Sepolia is added as default for new wallets and fetches balance
25654.mp4

Verification passed on

Brave 1.44.109 Chromium: 106.0.5249.103 (Official Build) (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#15266
  • Verified deprecated networks are removed after update
  • Verified Sepolia & Goreli are the only two ETH test networks available after upgrade
  • Verified Sepolia is added as default for new wallets and fetches balance
25654.mp4

Verification passed on

Brave 1.44.109 Chromium: 106.0.5249.103 (Official Build) (arm64)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#15266
  • Verified deprecated networks are removed after update
  • Verified Sepolia & Goreli are the only two ETH test networks available after upgrade
  • Verified Sepolia is added as default for new wallets and fetches balance
25654.mov

@srirambv
Copy link
Contributor

srirambv commented Oct 7, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.44.109 x64 build

  • Verified steps from brave/brave-core#15266
  • Verified deprecated networks are removed after update
  • Verified Sepolia & Goreli are the only two ETH test networks available after upgrade
  • Verified Sepolia is added as default for new wallets and fetches balance
25654-ARM.mp4

@kjozwiak kjozwiak mentioned this issue Oct 12, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release #4
Development

Successfully merging a pull request may close this issue.

Prepare for upcoming deprecation of Ethereum testnets brave/brave-core
5 participants
@bbondy @kjozwiak @nvonpentz @srirambv @brave-builds