Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add option to enable/disable download bubbles #25611

Closed
timchilds opened this issue Sep 26, 2022 · 6 comments · Fixed by brave/brave-core#16556
Closed

[Android] Add option to enable/disable download bubbles #25611

timchilds opened this issue Sep 26, 2022 · 6 comments · Fixed by brave/brave-core#16556
Assignees
Labels

Comments

@timchilds
Copy link

timchilds commented Sep 26, 2022

Summary

A large number of users have complained about the download bubbles Chromium introduced earlier this year.

Bubble Examples:

Downloading File File Downloaded
Image Image

Complaints:

Requirements

We should disable the bubbles by default and add an option in download settings to allow users to switch the bubbles on/off.

Image

Copy

Show download progress notifications
On/Off

@deeppandya as discussed on triage call - let's also update the "ask where to save files" copy to:

"Ask where to save files (if SD card is detected)"

@timchilds
Copy link
Author

@rmcfadden3 please let us know if the copy in the description works?

@rmcfadden3
Copy link

@timchilds — Since the word "bubbles" is probably not well understood, in this case I'd recommend something more explicit like:

  • Show download progress notifications
  • Show "Downloading file" progress notifications
  • Show file-download progress notifications

@rmcfadden3 rmcfadden3 removed their assignment Sep 26, 2022
@timchilds
Copy link
Author

Thanks @rmcfadden3 👍 Makes sense - let's go with option 1.

@timchilds
Copy link
Author

@rmcfadden3 while discussing this with the team it was highlighted that the "ask when to save files" and "ask where to save files" copy does not really make sense to what the settings actually do.

image

It turns out "ask when to save files" is deprecated. So we'll just remove that as part of #25687.

"ask where to save files" is only relevant when the user has an SD card inserted in the device. It gives a choice then whether to download to internal storage or SD card. Could you please help with updated copy there? Something like:

"Ask where to save when an SD card is detected"

@rmcfadden3
Copy link

@timchilds — could we do a parenthetical here? So like"

"Ask where to save files (if SD card is detected)"

@Uni-verse
Copy link
Contributor

Verified on 1.49.118, Chromium 111.0.5563.50 using the following devices:

Samsung GS 21, Android 13
Samsung Tab S7, Android 12
Pixel 5, Android 8

  • Ensured copy update in downloads settings
  • Ensured that enabling download progress notification will enable download bubbles
GS 21 GS 21 GS 21
screenshot-1678203170354 screenshot-1678203243038 screenshot-1678203313298
Tab S7 Tab S7
screenshot-1678203813716 screenshot-1678203828776
Pixel Pixel
Screen Shot 2023-03-07 at 10 36 17 AM Screen Shot 2023-03-07 at 10 36 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants