Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless IPFS notifications on resume from sleep #25566

Closed
MikeBishop opened this issue Sep 22, 2022 · 3 comments
Closed

Useless IPFS notifications on resume from sleep #25566

MikeBishop opened this issue Sep 22, 2022 · 3 comments
Assignees

Comments

@MikeBishop
Copy link

Description

After enabling IPFS to run a local node, Brave sends desktop notifications that the node is down when the system resumes from sleep, followed a few seconds later by a notification that the IPFS node is back up. These notifications are useless in the course of normal sleep/resume; unless there's an IPFS navigation happening at that moment, the user likely doesn't care. The user might care if the node stays down for an extended period of time.

Steps to Reproduce

  1. Enable local IPFS node in Brave
  2. Put PC to sleep
  3. Resume PC from sleep

Actual result:

image

Expected result:

Just be quiet.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.43.93 Chromium: 105.0.5195.127 (Official Build) (64-bit)

Version/Channel Information:

Only tried current.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@rebron
Copy link
Collaborator

rebron commented Sep 23, 2022

cc: @spylogsster

@rebron rebron added feature/notifications priority/P4 Planned work. We expect to get to it "soon". labels Sep 23, 2022
@spylogsster
Copy link

cc @cypt4

@cypt4 cypt4 self-assigned this Sep 27, 2022
@vadimstruts
Copy link
Collaborator

The IPFS local node and scheme has been deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants