Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zh-CN lang code for Translate feature #25417

Closed
atuchin-m opened this issue Sep 15, 2022 · 3 comments · Fixed by brave/brave-core#15105
Closed

Fix zh-CN lang code for Translate feature #25417

atuchin-m opened this issue Sep 15, 2022 · 3 comments · Fixed by brave/brave-core#15105

Comments

@atuchin-m
Copy link
Contributor

atuchin-m commented Sep 15, 2022

The correct chromium code is zh-CN, not zh-Hans.
The backend is fixed here: brave/go-translate#18

For QA: after the fix simplified Chinese pages should be translatable.
Note the for prod users the issue should be fixed by enabling language list update: brave/brave-variations#366
Here the default value in the code should be changed. The default is used until the list is fetched from the backend (for example for restored pages right after the start) or if the fetch is disabled.

@stephendonner
Copy link

Verified PASSED using

Brave 1.45.74 Chromium: 106.0.5249.55 (Official Build) beta (x86_64)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS macOS Version 11.7 (Build 20G817)
  1. installed 1.45.74
  2. launched Brave
  3. loaded each of the sites
  4. waited
  5. clicked on English to translate

Confirmed I was able to translate Chinese (Simplified) to English.

china.com

Chinese English
Screen Shot 2022-09-26 at 6 53 06 PM Screen Shot 2022-09-26 at 6 56 51 PM

news.cn

Chinese English
Screen Shot 2022-09-26 at 6 56 04 PM Screen Shot 2022-09-26 at 6 56 38 PM

cn.chinadaily.com.cn

Chinese English
Screen Shot 2022-09-26 at 7 00 46 PM Screen Shot 2022-09-26 at 7 01 11 PM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 11 Version 21H2 (Build 22000.978)
  • Install 1.45.75
  • launch brave
  • loaded each of the sites
  • clicked on English to translate and waited
  • verified the site has been translated to English from Chinese (Simplified)

bjd.com.cn

Chinese English
image image

xinmin.cn

Chinese English
image image

yangtse.com

Chinese English
image image

Bug filed:

@GeetaSarvadnya
Copy link

Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.45.106

  1. installed 1.45.106
  2. launched Brave
  3. loaded each of the sites
  4. waited
  5. clicked on English to translate
  • Confirmed I was able to translate Chinese (Simplified) to English.

china.com

Chinese English
Screenshot_20221020-153006_Brave Screenshot_20221020-153024_Brave

news.cn

Chinese English
Screenshot_20221020-153119_Brave Screenshot_20221020-153143_Brave

cn.chinadaily.com.cn

Chinese English
Screenshot_20221020-153223_Brave Screenshot_20221020-153240_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants