Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge to Aurora button needs a locale string #25181

Closed
Douglashdaniel opened this issue Sep 2, 2022 · 1 comment · Fixed by brave/brave-core#14978
Closed

Bridge to Aurora button needs a locale string #25181

Douglashdaniel opened this issue Sep 2, 2022 · 1 comment · Fixed by brave/brave-core#14978
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@Douglashdaniel
Copy link

Description

Bridge to Aurora button needs a locale string

https://github.com/brave/brave-core/blob/master/components/brave_wallet_ui/components/desktop/views/portfolio/portfolio-asset.tsx#L613
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Sep 2, 2022
@Douglashdaniel Douglashdaniel self-assigned this Sep 2, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Sep 2, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel added this to the 1.45.x - Beta milestone Oct 17, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Linux
  • Verified Bridge to Aurora button is still shown and text is visible
  • image

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified Bridge to Aurora button is still shown and text is visible
    image

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (arm64)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS macOS Version 12.4 (Build 21F79)
  • Verified Bridge to Aurora button is still shown and text is visible
    image

@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Added missing Bridge to Aurora String brave/brave-core
2 participants
@srirambv @Douglashdaniel