Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verified creator criteria #25085

Closed
Miyayes opened this issue Aug 30, 2022 · 6 comments · Fixed by brave/brave-core#15167
Closed

Update verified creator criteria #25085

Miyayes opened this issue Aug 30, 2022 · 6 comments · Fixed by brave/brave-core#15167
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 30, 2022

Description

https://github.com/brave/internal/issues/898

@Miyayes
Copy link
Collaborator Author

Miyayes commented Aug 31, 2022

Split it into small PR and then medium sized PR (where we remove dead branches). Do small PR first — can defer medium PR.

@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 31, 2022
@Miyayes Miyayes assigned zenparsing and unassigned emerick Sep 16, 2022
@Miyayes Miyayes added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Sep 20, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 22, 2022
@deeppandya deeppandya added the OS/Android Fixes related to Android browser functionality label Sep 28, 2022
@deeppandya
Copy link

Added android label as per the discussion

@Miyayes
Copy link
Collaborator Author

Miyayes commented Oct 4, 2022

Uplift to 1.45.x: brave/brave-core#15176

@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2022

The above requires 1.45.87 or higher for 1.45.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 6, 2022

Verification PASSED on


Brave | 1.45.87 Chromium: 106.0.5249.91 (Official Build) beta (64-bit)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Windows 10 Version 21H2 (Build 19044.2006)

Clean Profile Checks - PASSED
  • Confirmed that the "connected" publisher appears "not verified" (no blue checkmark on the Rewards icon)
  • Confirmed that in the Rewards panel, the status is displayed as "Unverified Creator" and appropriate hover text is shown
  • Confirmed that in the tipping banner, the "creator is not signed up yet" message is displayed
  • Confirmed no "verified" checkmark displays on the tipping banner
  • Confirmed that when tipping this "connected" creator, using vBAT, a pending tip is created
Example Example Example Example Example
image image image image image

Also confirmed that if a connected creator is listed in the Auto Contribution list, it does not get any AC BAT:

Example Example
image image
Upgrade Profile Checks - PASSED
  1. Install release version (1.44.x) w/ staging env and reconcile interval
  2. Close and relaunch (pull griffin seed)
  3. Enable Rewards, claim UGP grant
  4. Populate AC list with a mix of creators, including at least one "connected" creator
  5. Do a one time tip for a "connected" creator
  6. Set up a monthly tip for "connected" creator
  7. Close Brave
  8. Rename profile to Beta (1.45.87)
  9. Launch with beta version which contains this fix
  10. Look at brave://rewards page --> "connected" creator are NOT displayed with the verified checkmark as expected
  11. Wait for reconcile interval to occur so AC & monthly tips are contributed
  12. AC and monthly tips are completed only for the verified creators
  13. Confirmed that monthly tips for the connected creators are NOT processed instead goes to the pending contribution table
Step 4 Step 5 Step 6 Step 10 Step 12 Step 12 Step 12 Step 12 Step 12
image image image image image image image image image

@LaurenWags
Copy link
Member

LaurenWags commented Oct 14, 2022

Verified on Google Pixel 3 XL with Android 12 running 1.45.100

Verified test plan from brave/brave-core#15167 (comment)

Clean Profile Checks - PASSED
  • Confirmed that the "connected" publisher appears "not verified" (no blue checkmark on the Rewards icon)
  • Confirmed that in the tipping banner, the "creator is not signed up yet" message is displayed
  • Confirmed no "verified" checkmark displays on the tipping banner
  • Confirmed that when tipping this "connected" creator, using vBAT, a pending tip is created
Example Example Example
Screenshot_20221014-094804 Screenshot_20221014-094830 Screenshot_20221014-094917

Also confirmed that if a connected creator is listed in the Auto Contribution list, it does not get any AC BAT:

Example Example
Screenshot_20221014-095421 Screenshot_20221114-095556
Upgrade Profile Checks - PASSED
  1. Install beta version of 1.44.x, use QA Prefs to set staging env and verbose logging. (I used 1.44.93)
  2. Close and relaunch as necessary.
  3. Enable Rewards, claim UGP grant
  4. Populate AC list with a mix of creators, including at least one "connected" creator
  5. Do a one time tip for a "connected" creator
  6. Set up a monthly tip for "connected" creator
  7. Close Brave
  8. Update to 1.45.x Beta for Rewards
  9. Launch
  10. Look at brave://rewards page
    --> "connected" creator no longer displays the verified checkmark in all places (AC, tips, monthly tips, statement, etc)
  11. Close and advance system date to reconcile date so AC & monthly tips are contributed
  12. AC and monthly tips are completed
    --> "connected" creator does not get the AC and monthly tip set up prior to upgrade
    --> the monthly tip was added to the "Pending contributions" list
    --> AC was only completed for fully KYC'd creators
Step 4 Step 5 Step 6 Step 10 Step 10 Step 12 Step 12 Step 12
Screenshot_20221014-105858 Screenshot_20221014-105906 Screenshot_20221014-105914 Screenshot_20221014-110205 Screenshot_20221014-110347 Screenshot_20221114-111028 Screenshot_20221114-111042 Screenshot_20221114-111106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants