Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users cannot connect their brave wallet to adobe accounts #25039

Closed
HEagle18 opened this issue Aug 29, 2022 · 2 comments · Fixed by brave/brave-core#15090
Closed

Users cannot connect their brave wallet to adobe accounts #25039

HEagle18 opened this issue Aug 29, 2022 · 2 comments · Fixed by brave/brave-core#15090
Assignees
@bbondy
Labels
bug feature/web3/wallet/core feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@HEagle18
Copy link

Description

After user signs the transaction they get an error with 'Something went wrong. Please try again later.' (https://connected-accounts.adobe.com/?)
https://bravesoftware.slack.com/archives/C02S9LFEXU4/p1661783493953629

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@HEagle18 HEagle18 added bug priority/P3 The next thing for us to work on. It'll ride the trains. OS/Desktop labels Aug 29, 2022
@bbondy
Copy link
Member

bbondy commented Sep 9, 2022

This turns out to be because the accounts we return EIP-55 checksumed addresses to dapps instead of what MetaMask does (lowercase accounts).

The connected account is sent up in a JSON structure to Adobe with a POST HTTPS request to https://connected-accounts.adobe.com/api/connection/metamask. If that address is not lowercase, the server responds with an HTTP status code of 400.

it looks like we're going to have to modify to return lowercase addresses for better MM compat.

@bbondy bbondy mentioned this issue Sep 13, 2022
Merged
25 tasks
@bbondy bbondy self-assigned this Sep 13, 2022
bbondy added a commit to brave/brave-core that referenced this issue Sep 18, 2022
@bbondy
Make Dapp addresses lowercase to be compatible with MM
cf87de6 
Fix brave/brave-browser#25039

Adobe connect MetaMask feature doesn't work for this URL: https://connected-accounts.adobe.com/

This turns out to be because the accounts we return EIP-55 checksumed addresses to Dapps instead of lowercase like MetaMask.

On this particular Adobe site, the connected account is sent up in a JSON structure to Adobe with a POST HTTPS request to
https://connected-accounts.adobe.com/api/connection/metamask.
If that address is not lowercase, the server responds with an HTTP status code of 400.
The Adobe site uses the address that is given from the `eth_requestAccounts` call they make.

MM has lowercase addresses for return info via these functions: `eth_requestAccounts`, `eth_accounts`, `eth_coinbase`, `wallet_requestPermissions`, and `wallet_getPermissions`
For the best possible webcompat we need to unfortunately follow their standard in the wild.
This pull requests makes the return values to Dapps lowercase.
@bbondy bbondy added this to the 1.45.x - Nightly milestone Sep 20, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 28, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Linux
  • Verified able to connect to Adobe accounts
25039.mp4

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified able to connect to Adobe accounts
25039.mp4

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (arm64)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS macOS Version 12.4 (Build 21F79)
  • Verified able to connect to Adobe accounts
25039.mov

@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
bug feature/web3/wallet/core feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Make Dapp addresses lowercase to be compatible with MM brave/brave-core
4 participants
@bbondy @HEagle18 @srirambv @LaurenWags