Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Added On column should show only date #2501

Closed
cezaraugusto opened this issue Dec 12, 2018 · 1 comment · Fixed by brave/brave-core#1155
Closed

Sync Added On column should show only date #2501

cezaraugusto opened this issue Dec 12, 2018 · 1 comment · Fixed by brave/brave-core#1155
Assignees
@darkdh @AlexeyBarabash
Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.60.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

Per @bradleyrichter suggestion, we should trim the date/time string to only show date. The column is really to help you notice a problem or an intruder.

cc @AlexeyBarabash @darkdh
@cezaraugusto cezaraugusto added this to the 1.x Backlog milestone Dec 12, 2018
@cezaraugusto cezaraugusto mentioned this issue Dec 12, 2018
Closed
@darkdh darkdh mentioned this issue Dec 19, 2018
Merged
18 tasks
@darkdh darkdh added the QA/Yes label Dec 19, 2018
@darkdh darkdh modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 19, 2018
@LaurenWags LaurenWags mentioned this issue Feb 5, 2019
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Feb 5, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.60.19 Chromium: 72.0.3626.81 (Official Build) beta(64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X

Also encountered and logged #3234

Verification passed on

Brave 0.60.25 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

@AlexeyBarabash AlexeyBarabash

Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Display device Added on by only date brave/brave-core
7 participants
@bbondy @cezaraugusto @darkdh @AlexeyBarabash @LaurenWags @btlechowski @GeetaSarvadnya