Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images blocked when device language is set to Japanese #2482

Closed
srirambv opened this issue Dec 12, 2018 · 2 comments · Fixed by brave/brave-core#1098
Closed

Images blocked when device language is set to Japanese #2482

srirambv opened this issue Dec 12, 2018 · 2 comments · Fixed by brave/brave-core#1098

Comments

@srirambv
Copy link
Contributor

Description

Cross posting issue from https://github.com/brave/browser-ios/issues/1811 which reproduces on Desktop as well

Steps to Reproduce

  1. Set device language to Engilsh(US)
  2. Visit https://curazy.com/archives/58896
  3. Ensure all images are loaded, shields shows 16 blocked items for adblock
    https://youtu.be/36iHqvPeAiw
  4. Change device language to Japanese
  5. Visit the same link/ reload the same page
  6. Images are blocked, adblock goes upto 61
    https://youtu.be/HvnqFkw8qIw

Actual result:

When device language is set to English
https://youtu.be/36iHqvPeAiw
When device language is set to Japanese
https://youtu.be/HvnqFkw8qIw

Expected result:

Should not block based on device language

Reproduces how often:

Easy

Brave version (brave://version info)

Release build 0.58.17

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @bbondy @lukemulks

@srirambv srirambv added bug feature/shields/adblock Blocking ads & trackers with Shields labels Dec 12, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 12, 2018
@lukemulks
Copy link

Only thing I would comment on from seeing the issue above is that when I repro'd from desktop, the device language (win10) was English.

The browser settings had the language set to Japanese.

Might not make much of a difference, but noting in case Chrome, etc. do not display the same issue from English OS + Japanese browser level settings.

@srirambv
Copy link
Contributor Author

srirambv commented Jan 4, 2019

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

ezgif com-video-to-gif

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X
  • Verified changing device language to Japanese, launching Brave, and navigating to site from description did not show images as blocked. Clicked on several links, verified images/cartoons displayed.

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 10

Tested on Win 10 VM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants