Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tooltip more noticeable in dark-mode #24814

Closed
josheleonard opened this issue Aug 19, 2022 · 1 comment · Fixed by brave/brave-core#14723
Closed

Make Tooltip more noticeable in dark-mode #24814

josheleonard opened this issue Aug 19, 2022 · 1 comment · Fixed by brave/brave-core#14723
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@josheleonard
Copy link

Description

The current background of the tooltip matches content background color.
Add a border to the tooltip to increase it's visibility

Steps to Reproduce

  1. Go to wallet onboarding
  2. Create a new wallet
  3. Enter text into the create password field

Actual result:

image

Expected result:

Screen Shot 2022-08-19 at 11 37 24 AM

Reproduces how often:

Easy

Miscellaneous Information:
@josheleonard josheleonard added QA/Yes release-notes/include OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Aug 19, 2022
@josheleonard josheleonard added this to the 1.44.x - Nightly milestone Aug 19, 2022
@josheleonard josheleonard self-assigned this Aug 19, 2022
@josheleonard josheleonard mentioned this issue Aug 19, 2022
Merged
25 tasks
@rebron rebron added the feature/web3/wallet Integrating Ethereum+ wallet support label Aug 19, 2022
@josheleonard josheleonard moved this to Done in Web3 Aug 19, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.93 Chromium: 105.0.5195.136 (Official Build) beta (64-bit)
Revision 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS Linux
Weak 1 Weak 2 Medium Strong
image image image image

Verification passed on

Brave 1.44.93 Chromium: 105.0.5195.136 (Official Build) beta (64-bit)
Revision 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS Windows 11 Version 21H2 (Build 22000.795)
Weak 1 Weak 2 Medium Strong
image image image image

Verification passed on

Brave 1.44.93 Chromium: 105.0.5195.136 (Official Build) beta (arm64)
Revision 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS macOS Version 12.4 (Build 21F79)
Weak 1 Weak 2 Medium Strong
image image image image

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

fix: more noticeable dark-mode tooltip brave/brave-core
3 participants
@rebron @srirambv @josheleonard