Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import from Opera #23738

Closed
spylogsster opened this issue Jun 28, 2022 · 2 comments · Fixed by brave/brave-core#14006
Closed

Import from Opera #23738

spylogsster opened this issue Jun 28, 2022 · 2 comments · Fixed by brave/brave-core#14006
Assignees
@spylogsster
Labels
feature/importer OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.43.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Jun 28, 2022 •
edited
Loading

Description

Follow-up to #23704
Currently not showing options to import Opera.

Steps to Reproduce

  1. Install Opera and have a valid profile with some usage.
  2. Visit brave://settings/importData
  3. Try to import profile

Actual result:

Profile not detected / shown in drop down

Expected result:

Profile should be detected / shown in profile
Should offer information that's available including bookmarks, history, and saved passwords

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:
@spylogsster spylogsster self-assigned this Jun 28, 2022
@spylogsster spylogsster changed the title Import from Vivaldi and Opera Import from Opera Jun 28, 2022
@spylogsster spylogsster mentioned this issue Jun 28, 2022
Closed
@spylogsster spylogsster added feature/importer priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 28, 2022
@spylogsster spylogsster mentioned this issue Jun 29, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 21, 2022
@stephendonner
Copy link

stephendonner commented Aug 11, 2022 •
edited
Loading

Verification PASSED using

Brave 1.43.63 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Prerequisite: Download Opera and create data to import

Default - Downloaded Opera and added history/bookmarks/saved passwords

history bookmarks extensions saved passwords
Screen Shot 2022-08-11 at 11 30 00 AM Screen Shot 2022-08-11 at 11 30 20 AM Screen Shot 2022-08-11 at 11 30 54 AM Screen Shot 2022-08-11 at 11 36 20 AM

Case 1: Opera import from clicking Import bookmarks now... link on the bookmarks bar - PASSED (*)

  1. Install 1.43.63
  2. launch Brave
  3. click Skip welcome tour
  4. click Import bookmarks now... in the bookmarks bar
  5. confirmed Opera option displayed in the Import bookmarks and settings modal dropdown
  6. Select Opera Default
  7. keep default selections
    • Browsing history
    • Favorites/Bookmarks
    • Saved passwords
  8. click Import
  9. confirmation modal Your bookmarks and settings are ready is displayed as it's existing functionality
  10. click Done
  11. confirmed Favorites/Bookmarks shown in the bookmarks bar and sidebar and in brave://bookmarks
  12. confirmed Browsing history is imported and shown in brave://history
  13. confirmed Saved passwords is imported and shown in brave://settings/passwords
  14. All Browsing history/Favorites/Bookmarks/Saved passwords are imported from Opera correctly
  15. clicked on a bookmark (dw.com) and confirmed the site is loaded
Steps 6 & 7 Step 9 Step 11 Step12 Step 13 Step 14 Step 15
Screen Shot 2022-08-11 at 11 43 36 AM Screen Shot 2022-08-11 at 11 43 45 AM Screen Shot 2022-08-11 at 11 44 20 AM Screen Shot 2022-08-11 at 11 44 58 AM Screen Shot 2022-08-11 at 11 45 20 AM Screen Shot 2022-08-11 at 12 41 04 PM Screen Shot 2022-08-11 at 11 45 30 AM

Case 2: Opera import from brave://settings/importData - PASSED

  1. new profile
  2. launch Brave
  3. click Skip welcome tour
  4. visit brave://settings/importData
  5. select Opera Default from the drop-down list in the Import bookmarks and settings dialog
  6. select Favorites/Bookmarks and Browsing history
  7. click import
  8. confirmation modal Your bookmarks and settings are ready is displayed as it's existing functionality
  9. click Done
  10. confirmed Favorites/Bookmarks shown in the bookmarks bar and sidebar and in brave://bookmarks
  11. confirmed Browsing history is imported and shown brave://history
  12. clicked on a bookmark (https://www.att.com/internet/fiber) and confirmed the site is loaded
Steps 5 & 6 Step 8 Step 10 Step11 Step 12
Screen Shot 2022-08-11 at 4 06 31 PM Screen Shot 2022-08-11 at 4 09 43 PM Screen Shot 2022-08-11 at 4 10 28 PM Screen Shot 2022-08-11 at 4 10 38 PM Screen Shot 2022-08-11 at 4 12 31 PM

Case 3: Bookmarks imported from Opera should Sync between devices - PASSED

device 1

  1. new profile
  2. launch Brave
  3. click Import bookmarks now... in the bookmarks bar
  4. select Opera Default from Import bookmarks and settings modal
  5. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions, and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions
  7. visit brave://sync
  8. click on Start using sync ---> Start a new Sync Chain
  9. click Computer
  10. copy the code words
  11. under Sync Settings, click on the Sync everything radio button
Step 5 Step6 Step10 Step 11
Screen Shot 2022-08-11 at 9 34 16 PM Screen Shot 2022-08-11 at 9 48 59 PM Screen Shot 2022-08-11 at 9 50 35 PM Screen Shot 2022-08-11 at 9 51 00 PM

device 2

  1. go to device 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle
  8. confirmed Favorites/Bookmarks, Saved Passwords, Extensions synced successfully
  9. confirmed Browsing history not synced. Only URLs of the sites that were visited in the session are synced
Step 4 Step 7 Steps 8 & 9
image image (1) image (2)

Case 4: Upgrade 1.42.88--->1.43.63 - PASSED

  1. install 1.42.88
  2. launch Brave
  3. click Import bookmarks now... link in the bookmarks bar
  4. select Chrome in the Import bookmarks and settings modal dialog
  5. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions and finish the import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions into Brave
  7. close the browser
  8. install 1.43.63
  9. relaunch Brave
  10. Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions are retained
  11. go to Hamburger menu >>Bookmarks >> Import bookmarks and settings
  12. confirmed Opera Default is listed in the drop down menu of Import bookmarks and settings modal
  13. select Opera Default and keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords
  14. complete import
  15. confirmed successfully imported Browsing history, Favorites/Bookmarks, and Saved Passwords from Opera
Step 4 Step 5 Step 6 Steps 12 & 13 Step 14 Step 15
Screen Shot 2022-08-11 at 4 19 44 PM Screen Shot 2022-08-11 at 4 24 06 PM Screen Shot 2022-08-11 at 4 26 26 PM Screen Shot 2022-08-11 at 4 32 20 PM Screen Shot 2022-08-11 at 4 32 41 PM Screen Shot 2022-08-11 at 4 37 17 PM

Encountered:

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 11, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 18, 2022 •
edited
Loading

Verification Passed using

Brave | 1.43.61 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.795)

Prerequisite: Download Opera and create data to import

Default - Downloaded Opera and added history/bookmarks/saved passwords

history bookmarks extensions saved passwords
image image image image

Case 1: Opera import from clicking Import bookmarks now... link on the bookmarks bar - PASSED

  1. Install 1.43.74
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. confirmed Opera option displayed in the Import bookmarks and settings modal drop down
  5. Select Opera Default
  6. keep default selections
    • Browsing history
    • Favorites/Bookmarks
    • Saved passwords
  7. click import
  8. confirmation modal Your bookmarks and settings are ready is displayed as it's existing functionality
  9. click Done
  10. confirmed Favorites/Bookmarks shown in the bookmarks bar and sidebar and in brave://bookmarks
  11. confirmed Browsing history is imported and shown brave://history
  12. confirmed Saved passwords imported and shown brave://settings/passwords
  13. all Browsing history/Favorites/Bookmarks are imported from Opera correctly
  14. clicked on a bookmark (nytimes.com) and the site is loaded
Step 5 & 6 Step 8 Step 10 Step11
image image image image

Case 2: Opera import from brave://settings/importData - PASSED

  1. new profile
  2. launch Brave
  3. visit brave://settings/importData
  4. select Opera Default from the drop down list in the Import bookmarks and settings
  5. select Favorites/Bookmarks and Browsing history
  6. click import
  7. confirmation modal Your bookmarks and settings are ready is displayed as it's existing functionality
  8. click Done
  9. confirmed Favorites/Bookmarks shown in the bookmarks bar and sidebar and in brave://bookmarks
  10. confirmed Browsing history is imported and shown brave://history
  11. clicked on a bookmark (nytimes.com) and the site is loaded
Step 4-7 Step 8 Step 9 Step10 Step 11
image image image image image

Case 3: Bookmarks imported from Opera should Sync between devices - PASSED

device 1 (Windows)

  1. new profile
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. select Opera Default from `Import bookmarks and settings modal
  5. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords
  7. visit brave://sync
  8. click on Start using sync>> Start a new Sync Chain
  9. click Computer
  10. copy the code words
  11. under Sync Settings, click on the `Sync everything'
Step4-5 Step 6_bookmarks Step6-history Step 6-passwords Step 10-11
image image image image image

*device 2 (Linux) *

  1. go to device 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle
  8. confirmed Favorites/Bookmarks, Saved Passwords synced successfully
  9. confirmed Browsing history not synced. Only URLs of the sites that were visited in the session are synced

</detail

Step 4-6 Step 7 Step8 Step8 Step9
image image image image image

Case 4: Upgrade 1.42.88--->1.43.74

  1. install 1.42.97
  2. launch Brave
  3. click Import bookmarks now... link in the bookmarks bar
  4. select Chrome Person 1 in the Import bookmarks and settings modal
  5. select Browsing history, Favorites/Bookmarks and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions into Brave
  7. close the browser
  8. install 1.43.74
  9. relaunch Brave
  10. Browsing history, Favorites/Bookmarks are retained
  11. go to Hamburger menu>>Bookmarks>>Import bookmarks and settings
  12. confirmed 'Opera Defaultis listed in the drop down menu of Import bookmarks and settings` modal
  13. select Opera Default and keep default selections of Browsing history, Favorites/Bookmarks
  14. complete import
  15. confirmed successfully imported Browsing history and Favorites/Bookmarks from Opera
Step 1 Step 4- 5 Step5- 6 Step 10 Step 13-14 Step 15
Step 1 Step 4-6 Step 6 Step 10 Step 13-14 Step 15

Verification PASSED using

Brave | 1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Linux
JavaScript | V8 10.4.132.22

Bug filed: ##24827

Prerequisite: Download Opera and create data to import

Default - Downloaded Opera and added history/bookmarks/saved passwords

history bookmarks extensions saved passwords
image image image image

Case 1: Opera import from clicking Import bookmarks now... link on the bookmarks bar - PASSED

  1. Install 1.43.74
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. confirmed Opera option displayed in the Import bookmarks and settings modal drop down
  5. Select Opera Default
  6. keep default selections
    • Browsing history
    • Favorites/Bookmarks
    • Saved passwords
  7. click import
  8. confirmation modal Your bookmarks and settings are ready is displayed as it's existing functionality
  9. click Done
  10. confirmed Favorites/Bookmarks shown in the bookmarks bar and sidebar and in brave://bookmarks
  11. confirmed Browsing history is imported and shown brave://history
  12. confirmed Saved passwords imported and shown brave://settings/passwords
  13. all Browsing history/Favorites/Bookmarks are imported from Opera correctly
  14. clicked on a bookmark (nytimes.com) and the site is loaded
Step 5 & 6 Step 8 Step 10 Step11
image image image image

Case 2: Opera import from brave://settings/importData - PASSED

  1. new profile
  2. launch Brave
  3. visit brave://settings/importData
  4. select Opera Default from the drop down list in the Import bookmarks and settings
  5. select Favorites/Bookmarks and Browsing history
  6. click import
  7. confirmation modal Your bookmarks and settings are ready is displayed as it's existing functionality
  8. click Done
  9. confirmed Favorites/Bookmarks shown in the bookmarks bar and sidebar and in brave://bookmarks
  10. confirmed Browsing history is imported and shown brave://history
  11. clicked on a bookmark (nytimes.com) and the site is loaded
Step 4-7 Step 8 Step 9 Step10 Step 11
image image image image image

Case 3: Bookmarks imported from Opera should Sync between devices - PASSED

device 1 (Windows)

  1. new profile
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. select Opera Default from `Import bookmarks and settings modal
  5. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords
  7. visit brave://sync
  8. click on Start using sync>> Start a new Sync Chain
  9. click Computer
  10. copy the code words
  11. under Sync Settings, click on the `Sync everything'
Step4-5 Step 6_bookmarks Step6-history Step 6-passwords Step 10-11
image image image image image

*device 2 (Linux) *

  1. go to device 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle
  8. confirmed Favorites/Bookmarks, Saved Passwords synced successfully
  9. confirmed Browsing history not synced. Only URLs of the sites that were visited in the session are synced

</detail

Step 4-6 Step 7 Step8 Step8 Step9
image image image image image

Case 4: Upgrade 1.42.88--->1.43.61

  1. install 1.42.97
  2. launch Brave
  3. click Import bookmarks now... link in the bookmarks bar
  4. select Chrome Person 1 in the Import bookmarks and settings modal
  5. select Browsing history, Favorites/Bookmarks and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions into Brave
  7. close the browser
  8. install 1.43.74
  9. relaunch Brave
  10. Browsing history, Favorites/Bookmarks are retained
  11. go to Hamburger menu>>Bookmarks>>Import bookmarks and settings
  12. confirmed 'Opera Defaultis listed in the drop down menu of Import bookmarks and settings` modal
  13. select Opera Default and keep default selections of Browsing history, Favorites/Bookmarks
  14. complete import
  15. confirmed successfully imported Browsing history and Favorites/Bookmarks from Opera
Step 1 Step 4- 5 Step5- 6 Step 10 Step 13-14 Step 15
Step 1 Step 4-6 Step 6 Step 10 Step 13-14 Step 15

This was referenced Aug 31, 2022
Closed
Closed
@bsclifton bsclifton mentioned this issue Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/importer OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Import from Opera brave/brave-core
5 participants
@stephendonner @spylogsster @LaurenWags @brave-builds @MadhaviSeelam