Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a place holder text while panel is loading the transaction values #23663

Closed
srirambv opened this issue Jun 24, 2022 · 2 comments · Fixed by brave/brave-core#16945
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Have a place holder text while panel is loading the transaction values

Steps to Reproduce

  1. Submit a Sign and Send transaction on https://pwgoom.csb.app/
  2. Panel loads and enables confirm button but the total value is still not populated on the panel

Actual result:

Placeholder.mp4

Expected result:

Should not enable Confirm button till the values are populated in the panel or have a Loading values placeholder text on panel while the values are populated

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.42.24 Chromium: 103.0.5060.53 (Official Build) nightly (64-bit)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS Windows 11 Version 21H2 (Build 22000.739)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @yrliou this also happens on other EVM's tokens as well where the total value is being loaded but before loading confirm button is enabled. NOTE: This is not a problem when you view the panel in tab via brave://wallet-panel.top-chrome

@jamesmudgett
Copy link

@Douglashdaniel needs loading skeleton

@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Jan 12, 2023
@josheleonard josheleonard self-assigned this Jan 30, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 3, 2023
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from brave/brave-core#16945
  • Verified loading skeleton is shown when the values are being fetched
  • Verified Unable to fetch fee estimates error is shown when network doesn't match
23663.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#16945
  • Verified loading skeleton is shown when the values are being fetched
  • Verified Unable to fetch fee estimates error is shown when network doesn't match
23663.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16945
  • Verified loading skeleton is shown when the values are being fetched
  • Verified Unable to fetch fee estimates error is shown when network doesn't match
23663.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants