Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filecoin network chooser #23368

Closed
cypt4 opened this issue Jun 9, 2022 · 2 comments · Fixed by brave/brave-core#13895
Closed

Add filecoin network chooser #23368

cypt4 opened this issue Jun 9, 2022 · 2 comments · Fixed by brave/brave-core#13895
Assignees
@cypt4
Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.43.x - Release

Comments

@cypt4
Copy link

cypt4 commented Jun 9, 2022 •
edited
Loading

We need to add additional row with filecoin testnet in create new account option.
Also we need to add chooser for filecoin network when import hardware filecoin account.
Base branch is origin/brave_23241.
For adding account AddFilecoinAccount(string accountName, string fileCoinNetwork) => (bool success); method should be used.
Where filecoin network is filecoin chain_id which is "t" or "f";
For the chooser, when we import hardware account, HardwareWalletAccount struct now has optional "network" field with same scope("t" or "f").
Chooser when import account by private key is already working.
@cypt4 cypt4 added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 9, 2022
@cypt4 cypt4 changed the title Add filecoin testnet chooser Add filecoin network chooser Jun 9, 2022
@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/filecoin labels Jun 9, 2022
@cypt4 cypt4 self-assigned this Jun 9, 2022
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 17, 2022
@cypt4 cypt4 mentioned this issue Jun 22, 2022
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Jun 23, 2022
@cypt4
Add filecoin testnet support
5f8d7c5 
Resolves brave/brave-browser#23368
Resolves brave/brave-browser#23241
Add separate keyring id for filecoin.
Add ui tweaks to support new keyring.
cypt4 added a commit to brave/brave-core that referenced this issue Jul 1, 2022
@cypt4
Add filecoin testnet support
a7260aa 
Resolves brave/brave-browser#23368
Resolves brave/brave-browser#23241
Add separate keyring id for filecoin.
Add ui tweaks to support new keyring.
cypt4 added a commit to brave/brave-core that referenced this issue Jul 5, 2022
@cypt4
Add filecoin testnet support
aa7e0e8 
Resolves brave/brave-browser#23368
Resolves brave/brave-browser#23241
Add separate keyring id for filecoin.
Add ui tweaks to support new keyring.
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 12, 2022
@srirambv srirambv added the QA/Yes label Aug 3, 2022
@srirambv
Copy link
Contributor

Removing Android label since Filecoin isn't supported on Mobile yet.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Aug 19, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Linux
  • Verified steps from brave/brave-core#13895
  • Verified Filecoin mainnet accounts have a different naming convention starting with f
  • Verified Filecoin testnet accounts have a different naming convention starting with t
  • Verified when no Filecoin account is created, selecting Filecoin (Mainnet/Testnet) prompts to create an account on the selected network
  • Verified able to create both Mainnet and Testnet accounts and are listed one below the other irrespective of how its created
  • Verified transaction works on Mainnet
  • Encountered #24824, #24946, #24947 & #24949

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from brave/brave-core#13895
  • Verified Filecoin mainnet accounts have a different naming convention starting with f
  • Verified Filecoin testnet accounts have a different naming convention starting with t
  • Verified when no Filecoin account is created, selecting Filecoin (Mainnet/Testnet) prompts to create an account on the selected network
  • Verified able to create both Mainnet and Testnet accounts and are listed one below the other irrespective of how its created
  • Verified transaction works on Mainnet
  • Encountered #24824, #24946, #24947 & #24949

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (arm64)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#13895
  • Verified Filecoin mainnet accounts have a different naming convention starting with f
  • Verified Filecoin testnet accounts have a different naming convention starting with t
  • Verified when no Filecoin account is created, selecting Filecoin (Mainnet/Testnet) prompts to create an account on the selected network
  • Verified able to create both Mainnet and Testnet accounts and are listed one below the other irrespective of how its created
  • Verified transaction works on Mainnet
  • Encountered #24824, #24946, #24947 & #24949

@LaurenWags LaurenWags mentioned this issue Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Add filecoin testnet support brave/brave-core
6 participants
@jamesmudgett @bbondy @yrliou @srirambv @brave-builds @cypt4