Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Buys on wallet are hardcoded in the url to USD #23295

Closed
HEagle18 opened this issue Jun 7, 2022 · 3 comments · Fixed by brave/brave-core#13811 or brave/brave-core#14089
Closed

Bug - Buys on wallet are hardcoded in the url to USD #23295

HEagle18 opened this issue Jun 7, 2022 · 3 comments · Fixed by brave/brave-core#13811 or brave/brave-core#14089
Assignees
@muliswilliam
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@HEagle18
Copy link

HEagle18 commented Jun 7, 2022 •
edited by muliswilliam
Loading

Description

BuyUrl for all ramp providers currently hard code fiat currency to USD, as a result, a user's preferred currency is not used used in on ramp provider's UI. This creates a confusing UX for users.
@HEagle18 HEagle18 added bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Jun 7, 2022
@muliswilliam muliswilliam moved this to In Progress in Web3 Jun 10, 2022
@muliswilliam muliswilliam added this to the 1.40.x - Beta milestone Jun 10, 2022
@muliswilliam muliswilliam mentioned this issue Jun 16, 2022
Merged
25 tasks
@kjozwiak kjozwiak removed this from the 1.40.x - Release milestone Jun 19, 2022
@muliswilliam muliswilliam moved this from In Progress to In Review in Web3 Jun 21, 2022
Repository owner moved this from In Review to Done in Web3 Jul 7, 2022
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 7, 2022
@yrliou yrliou removed this from the 1.43.x - Nightly milestone Jul 7, 2022
@yrliou yrliou moved this from Done to In Progress in Web3 Jul 7, 2022
@yrliou
Copy link
Member

yrliou commented Jul 7, 2022 •
edited
Loading

Reverted via brave/brave-core#14075 due to iOS build breakage.

@yrliou yrliou reopened this Jul 7, 2022
@muliswilliam muliswilliam mentioned this issue Jul 8, 2022
Merged
25 tasks
@muliswilliam muliswilliam moved this from In Progress to In Review in Web3 Jul 14, 2022
Repository owner moved this from In Review to Done in Web3 Jul 28, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Jul 28, 2022
@brave-builds brave-builds mentioned this issue Jul 28, 2022
Closed
7 tasks
This was referenced Sep 19, 2022
Closed
Closed
@srirambv
Copy link
Contributor

Removing Android and iOS labels as they need frontend work to be done.

Android specific issue : #25477
iOS specific issue: brave/brave-ios#6032

@srirambv srirambv removed OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality labels Sep 19, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.95 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Linux
23295.mp4

Verification passed on

Brave 1.44.95 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Windows 11 Version 21H2 (Build 22000.978)
23295.mp4

Verification passed on

Brave 1.44.95 Chromium: 106.0.5249.40 (Official Build) (arm64)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS macOS Version 12.4 (Build 21F79)
23295.mov

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release
6 participants
@kjozwiak @yrliou @HEagle18 @srirambv @brave-builds @muliswilliam