crash on starting download

[hyperfekt]

Description

Starting a download will sometimes instantly crash Brave.

Steps to Reproduce

1. Browse.
2. Click link to file.

Actual result:

The Brave window vanishes, leaving no related information on stderr. After starting Brave again, it offers to restore tabs. Restoring tabs and clicking the same download link works just fine. Issue may occur again later in the same session with a different download link.

Expected result:

As most of the time, the file save dialog opens.

Reproduces how often:

Intermittent issue

Brave version (brave://version info)

Adapted from .deb package as part of Nix.

Brave	0.56.12 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Linux
JavaScript	V8 7.0.276.32
Flash	(Disabled)
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36
Command Line	/run/current-system/sw/bin/brave --enable-tab-audio-muting --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=EnableEmojiContextMenu,DesktopPWAWindowing,fill-on-account-select,NewExtensionUpdaterService --disable-features=SharedArrayBuffer,DefaultEnableOopRasterization,VizDisplayCompositor,AutofillSaveCardSignInAfterLocalSave,kAutofillServerCommunication --flag-switches-begin --flag-switches-end
Executable Path	/nix/store/mhw7141k0q659qx1a5f79fgk292w9gjn-brave/opt/brave.com/brave/brave-browser
Profile Path	/home/adrian/.config/BraveSoftware/Brave-Browser/Default
Variations	c134752e-f685ead32c707b42-dcf7018a411b6d4e-3f4a17dfd01ab0d3-488f2d523e006338-3f4a17df1a0d11d4-3f4a17dfe202a358-3f4a17dfebeb14fc-3f4a17dfb7e2524c-3f4a17df6c18ba9d-3d98b30261832c80-3f4a17dfcc20827f-77c422c9041608a-3f4a17df2db4845-ace4e138241fff6c-4eda1c578502ae4f-6b5e5ddf9853922b-3f4a17df125b7f68-3f4a17df9ca1387e-3f4a17df1149accc-3f4a17df776de70c-e0278d3ded9149a9-3f4a17df34d450b1-3f4a17df15d89564-80f9a33e8ee5ed19-c3125ea274658432-fa79b94ced7ba060-3f4a17df121ae2bc-65969d679e201a2b-3f4a17df591576c8-3f4a17df249dd49a-3f4a17df5274eb09-3f4a17dfceff87ec-3f4a17df44827ee5-3f4a17df8f1e27f-3f4a17dfedbcf7c5-ddf1844d77bbdddc-3f4a17df5485fc4d-3f4a17df93731dca-3f4a17df9b4c4257-3f4a17df8fa604e0-ace4e13843f62d3b-3f4a17df9e5c75f1-30e1b12b6fa07eb4-7282ca762981bcb4-3f4a17df2b86fd96-3f4a17df5139837c-3f4a17df4934552d-3f4a17df7f8176d9-3f4a17df296e6ad7-4cfc7c42f7217a71-b204717823a898eb-fc93cf747a5ba892-3f4a17dfd1cd70a5-675921444ea303a6-3f4a17dfb19465ab-b19465ab6e6e0c7e-3f17a7d895876445-400575afd92562a9-441539fd2b33233e-881ca6c94da5ae82-3f4a17df56302f8c-2f882e7014c5a050-61ceed182c1d398c-3f4a17dfcc54eb06-3f4a17df4932440-d21eb72dad6d27cc-3e870323df072bba-9a6c5085f56e0452-3f4a17df8576baf1-3f4a17df3038aa2e-3f4a17df51b9b54d-3f4a17df4bc337ce-535cb40a9a2f4e5b-4bc735ae1354da85-f1a864dc17507c76-3f4a17df494d8760-3f4a17df34baa302-cf4f6ead587fa7b2-726d8ace3a4029d-d7f231f3bbb8f811-3f4a17df41aa6aaa-da82a76f94e68624-803f8fc4cc73f8a1-3f4a17df8834fcca-3f4a17df11d91db8-d93a0620ea0f933d-3f4a17df493ac2c5-803f8fc4

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?

Will update as further testing occurred.

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Will update as further testing occurred.

Additional Information

[srirambv]

What file are you downloading? Is it a Torrent file? Whats the size of the download? Please provide more info on the link from which you are downloading

[hyperfekt]

I've now managed to reproduce this more reliably, using this file.
I'm also getting an error message with it:

(brave:4152): GLib-GIO-ERROR **: 10:45:46.343: No GSettings schemas are installed on the system
Trace/breakpoint trap

It appears to be an issue local to my distro, I will apply a fix to the package.

EDIT: Fixed in NixOS/nixpkgs#50450.