Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Asset icon on Brave Wallet (Crypto) #20649

Closed
srirambv opened this issue Jan 24, 2022 · 4 comments
Closed

Incorrect Asset icon on Brave Wallet (Crypto) #20649

srirambv opened this issue Jan 24, 2022 · 4 comments
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

Description

Incorrect Asset icon on Brave Wallet (Crypto)

Steps to reproduce

  1. Clean install 1.36.57 x64 Nightly build
  2. Enable Brave Wallet
  3. Skip onboarding for backup key
  4. Once portfolio loads shows ETH & BAT both having ETH icon

Actual result

Expected result

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: 11

Brave version

1.36.57

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky @wchen342

@srirambv srirambv added QA/Yes release-notes/exclude regression feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 24, 2022
@SergeyZhukovsky
Copy link
Member

@srirambv I tried on 3 diff devices with a fresh nightly(it's 1.36.58 currently). Samsung Galaxy S10, Pixel 6 and Motorola One Vision. I see correct icons on all of them. Do you have more details?

@srirambv
Copy link
Contributor Author

Issue happened on CR98 build

@samartnik
Copy link
Contributor

Problem was with components loading, fixed in cr98 brave/brave-core@47d09ff

@samartnik samartnik added this to the 1.36.x - Nightly milestone Jan 25, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Feb 7, 2022

Verification passed on the following devices running 1.36.85 x64 beta build

  • Verified individual token icon is shown correctly
Oppo Reno 5 (Android 11) Samsung Tab A (Android 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants