Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed Url should read Feed URL #20638

Closed
stephendonner opened this issue Jan 23, 2022 · 8 comments · Fixed by brave/brave-core#12431
Closed

Feed Url should read Feed URL #20638

stephendonner opened this issue Jan 23, 2022 · 8 comments · Fixed by brave/brave-core#12431
Assignees
Labels

Comments

@stephendonner
Copy link

Description

Feed Url should read Feed URL

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. opt in to Brave News
  4. click on Customize on the new-tab page
  5. click on Brave News
  6. look beneath Your Sources

Actual result:

It reads Feed Url

feed-url

Expected result:

Should read Feed URL

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.36.60 Chromium: 97.0.4692.99 (Official Build) nightly (64-bit)
Revision d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
OS Windows 10 Version 20H2 (Build 19042.1466)
@ash1895-web
Copy link

I would like to work on this issue. Can you please assign this to me?

@srirambv
Copy link
Contributor

@ash1895-web Please create a PR for the fix. I've assigned the issue to you

@ash1895-web
Copy link

Thanks @srirambv for assigning the issue.

@ash1895-web
Copy link

Hello @srirambv , I am trying to clone the repository from last 20 hours but the process is still not completed. Is this a normal behaviour? or may be it is too much to bear for my intel i3 ?

@srirambv
Copy link
Contributor

srirambv commented Feb 4, 2022

I am trying to clone the repository from last 20 hours

Cloning the brave repo is taking that long or building the code?

@ash1895-web
Copy link

Cloning

@mattmcalister mattmcalister added the priority/P4 Planned work. We expect to get to it "soon". label Mar 11, 2022
@Tonev
Copy link
Contributor

Tonev commented Apr 10, 2022

@stephendonner

I think this one should be closed as resolved for brave/brave-core#12431 was merged successfully.

@stephendonner stephendonner added this to the 1.38.x - Beta milestone Apr 12, 2022
@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed the string now reads Feed URL

Screen Shot 2022-04-12 at 2 16 28 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants