Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relaunch buttons don't display if rewards is enabled while brave://settings/rewards is opened/active tab #19676

Closed
kjozwiak opened this issue Nov 23, 2021 · 1 comment · Fixed by brave/brave-core#11238

Comments

@kjozwiak
Copy link
Member

Description

When you enable rewards using the panel after initiating the rewards panel via brave://settings/rewards, you'll notice that enabling/disabling the inline tip settings won't display a relaunch button as per brave/brave-core#11157.

Steps to Reproduce

  1. launch Brave with a new profile
  2. once launched, open brave://settings/rewards (in my case, this was the only tab opened)
  3. click on the button that toggles the rewards panel and enable rewards
  4. you'll notice that brave://settings/rewards will get populated once rewards is enabled
  5. toggle the inline tip settings under Tip buttons and you'll notice that the Relaunch button isn't being displayed

Note: Closing/re-opening brave://settings/rewards fixes the issue so the above isn't a high priority issue.

Actual result:

issue

Expected result:

image

Reproduces how often:

100% reproducible using the above STR. @stephendonner also confirmed/reproduced.

Brave version (brave://version info)

Brave | 1.34.28 Chromium: 96.0.4664.45 (Official Build) nightly (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 11 Version 21H2 (Build 22000.318)

Version/Channel Information:

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @Miyayes @LaurenWags @emerick

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 30, 2021

Verification passed on


Brave | 1.33.94 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 10 Version 21H2 (Build 19044.1387)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment