Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked count overlaps with text when it goes beyond 3 digits #1951

Closed
srirambv opened this issue Nov 1, 2018 · 2 comments · Fixed by brave/brave-extension#82
Closed

Blocked count overlaps with text when it goes beyond 3 digits #1951

srirambv opened this issue Nov 1, 2018 · 2 comments · Fixed by brave/brave-extension#82
Assignees
Labels
bug design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 1, 2018

Description

Blocked count overlaps with text when it goes beyond 3 digits

Actual result:

image

Expected result:

Blocked count shouldn't overlap on text

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes on Beta

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @karenkliu @rebron @kjozwiak

@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 1, 2018
@karenkliu karenkliu added the design A design change, especially one which needs input from the design team label Nov 1, 2018
@tildelowengrimm tildelowengrimm added the feature/shields/panel Front-end design and functionality of the Shields panel. label Nov 2, 2018
@kjozwiak kjozwiak added the QA/Yes label Nov 5, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@bsclifton bsclifton modified the milestones: 1.x Backlog, 0.58.x - Dev Nov 7, 2018
@bsclifton
Copy link
Member

Updated to be 0.58.x after DEPS was updated with brave/brave-core#820

PR is tagged with uplift-request; let's make sure to modify milestone if that is approved 😄

@LaurenWags
Copy link
Member

LaurenWags commented Dec 4, 2018

Verified passed with

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Mac OS X

Verification passed on

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Windows

image

Verification passed on

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

screenshot from 2018-12-06 23-43-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants