Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CTA to buy on vpn panel #19406

Closed
nullhook opened this issue Nov 12, 2021 · 2 comments · Fixed by brave/brave-core#11094
Closed

Change CTA to buy on vpn panel #19406

nullhook opened this issue Nov 12, 2021 · 2 comments · Fixed by brave/brave-core#11094
Assignees
@nullhook
Labels
feature/vpn OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.34.x - Release

Comments

@nullhook
Copy link

Change CTA to "Buy" for now on VPN panel
@nullhook nullhook self-assigned this Nov 12, 2021
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 12, 2021
@nullhook nullhook mentioned this issue Nov 15, 2021
Merged
24 tasks
@nullhook nullhook added this to the 1.34.x - Nightly milestone Nov 17, 2021
@LaurenWags
Copy link
Member

@nullhook what would the QA Test plan be for this one? cc @rebron @brave/legacy_qa

@rebron
Copy link
Collaborator

rebron commented Dec 14, 2021

Switching to QA/No. CTA to have "Buy" label vs having some arbitrary pricing that may have confused people who enabled the flag.

Checked on the following build with brave://flags/#brave-vpn enabled.

Brave 1.35.30 Chromium: 97.0.4692.45 (Official Build) nightly (arm64)
Revision 513579c4234d36379b32e422772546e885cef641-refs/branch-heads/4692@{#802}
OS macOS Version 12.1 (Build 21C5021h)

Screen Shot 2021-12-14 at 9 30 07 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
feature/vpn OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Removed price string in vpn sell panel brave/brave-core
3 participants
@rebron @nullhook @LaurenWags