Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish how the widget/portfolio page behave when you try to swap #19102

Closed
srirambv opened this issue Oct 29, 2021 · 2 comments
Closed

Polish how the widget/portfolio page behave when you try to swap #19102

srirambv opened this issue Oct 29, 2021 · 2 comments
Labels
closed/by-author feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude suggestion

Comments

@srirambv
Copy link
Contributor

Description

When trying to swap, portfolio page reloads causing the Swap button to change to Insufficient Funds momentarily but its quite prominent. We should make this more smooth so the button doesn't switch to Insufficient Funds

Steps to Reproduce

  1. Select Swap of tokens
  2. Click Swap to trigger panel to open
  3. Briefly swap button changes to Insufficient Funds

Actual result:

Linux.mov

Expected result:

Better handling of UI

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.84 Chromium: 95.0.4638.54 (Official Build) beta (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb @Douglashdaniel
Follow up to #18905

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 30, 2021
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Nov 8, 2021
@Douglashdaniel
Copy link

@srirambv Just tested this, seems like this is not occurring any more.
Might have been resolved by some other fix.
Are you able to confirm?

@srirambv
Copy link
Contributor Author

@Douglashdaniel yes the issue seems to be fixed now. I don't see the Insufficient funds message on the swap button when trying to swap. Closing as the issue is not reproducible anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/by-author feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude suggestion
Projects
None yet
Development

No branches or pull requests

3 participants