Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Block all text when there are no entries #1906

Closed
srirambv opened this issue Oct 30, 2018 · 3 comments
Closed

Remove Block all text when there are no entries #1906

srirambv opened this issue Oct 30, 2018 · 3 comments
Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Blocked QA/Yes release-notes/exclude
Milestone
0.57.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Remove Block all text when there are no entries

Steps to Reproduce

  1. Build from master
  2. Enable Scripts Blocked (text is also a little confusing) @karenkliu relating to the conversation on Shields v2 GA version brave-extension#70 (comment)
  3. Click on the expand button to see the items blocked
  4. Block all text is shown even though there are no items under allowed list

Actual result:

image

Expected result:

Should not have unwanted text which is confusing

Reproduces how often:

Easy

Brave version (brave://version info)

master

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @karenkliu @rebron @bsclifton @brave/legacy_qa
@srirambv srirambv added feature/shields The overall Shields feature in Brave. design A design change, especially one which needs input from the design team priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 30, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Oct 30, 2018
@karenkliu
Copy link

This issue will be fixed when we fix #1957

@tildelowengrimm tildelowengrimm added the feature/shields/panel Front-end design and functionality of the Shields panel. label Nov 2, 2018
@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed closed/duplicate Issue has already been reported labels Nov 14, 2018
@bbondy
Copy link
Member

bbondy commented Dec 2, 2018

Moving this to 0.57.x milestone since that's when it will be fixed as part of #1957

@bbondy bbondy added the QA/Yes label Dec 2, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 0.57.x - Release Dec 2, 2018
@LaurenWags LaurenWags mentioned this issue Dec 5, 2018
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Dec 5, 2018 •
edited
Loading

Issue not resolved. Logged #2371 for follow up. Marking as QA/Blocked.

cc @rebron @kjozwiak @srirambv

This was referenced Dec 7, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Blocked QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

No branches or pull requests
7 participants
@tildelowengrimm @bbondy @karenkliu @kjozwiak @rebron @srirambv @LaurenWags